Remove data-submit-wait attr from view el when resetting submit state

[jasonwebster]

This allows the submission prevention to operate correctly when the view's element is the form.

Fixes #322

[kpdecker]

Seems like it's better to do a conditional with this.$el rather than appending.

    add: function(selector,context){
      return $(uniq(this.concat($(selector,context))))
    },

Add introduces a bit of otherwise unnecessary memory churn which doesn't matter that much on the client but it does impact the server-side behaviors.

[jasonwebster]

TBH, if it were me, I'd just use this.el.removeAttribute

On Tuesday, 25 February 2014, Kevin Decker [email protected] wrote:

Seems like it's better to do a conditional with this.$el rather than
appending.

add: function(selector,context){
  return $(uniq(this.concat($(selector,context))))
},

Add introduces a bit of otherwise unnecessary memory churn which doesn't
matter that much on the client but it does impact the server-side behaviors.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/323#issuecomment-36078944
.

Jason Webster
CTO | www.metalabdesign.com

[kpdecker]

We should use $. I have grand plans on that front ;)

https://github.com/walmartlabs/fruit-loops

On Tue, Feb 25, 2014 at 7:15 PM, Jason Webster [email protected]:

TBH, if it were me, I'd just use this.el.removeAttribute

On Tuesday, 25 February 2014, Kevin Decker [email protected]
wrote:

Seems like it's better to do a conditional with this.$el rather than
appending.

add: function(selector,context){
return $(uniq(this.concat($(selector,context))))
},

Add introduces a bit of otherwise unnecessary memory churn which doesn't
matter that much on the client but it does impact the server-side
behaviors.

—
Reply to this email directly or view it on GitHub<
https://github.com/walmartlabs/thorax/pull/323#issuecomment-36078944>
.

Jason Webster
CTO | www.metalabdesign.com

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/323#issuecomment-36080121
.

[jasonwebster]

I'll update the PR.

On Tuesday, 25 February 2014, Kevin Decker [email protected] wrote:

We should use $. I have grand plans on that front ;)

https://github.com/walmartlabs/fruit-loops

On Tue, Feb 25, 2014 at 7:15 PM, Jason Webster <[email protected]javascript:_e(%7B%7D,'cvml','[email protected]');>wrote:

TBH, if it were me, I'd just use this.el.removeAttribute

On Tuesday, 25 February 2014, Kevin Decker <[email protected]javascript:_e(%7B%7D,'cvml','[email protected]');>

wrote:

Seems like it's better to do a conditional with this.$el rather than
appending.

add: function(selector,context){
return $(uniq(this.concat($(selector,context))))
},

Add introduces a bit of otherwise unnecessary memory churn which
doesn't
matter that much on the client but it does impact the server-side
behaviors.

—
Reply to this email directly or view it on GitHub<
https://github.com/walmartlabs/thorax/pull/323#issuecomment-36078944>
.

Jason Webster
CTO | www.metalabdesign.com

—
Reply to this email directly or view it on GitHub<
https://github.com/walmartlabs/thorax/pull/323#issuecomment-36080121>
.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/323#issuecomment-36082041
.

Jason Webster
CTO | www.metalabdesign.com

[jasonwebster]

Updated.

[kpdecker]

Released in 2.3.5