This repository has been archived by the owner on Mar 20, 2021. It is now read-only.
Always return 'this' from Thorax.View.render(). #312
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backbone's
view.render()
says:However,
Thorax.View.render()
returnsundefined
if there is noview.el
and theoutput
parameter passed torender()
in the other case. This PR switches both cases to returnthis
per the Backbone way.Note: This is technically a breaking change for anyone who relied on
output
being passed pack in a chain of some sort. I believe that behavior is completely undocumented, but I'm not sure what the expectations are in that regard./cc @kpdecker @eastridge