This repository has been archived by the owner on Mar 20, 2021. It is now read-only.
fetchQueue null check #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| this.fetchQueue._promise = $super.call(this, options); | ||
| return this.fetchQueue._promise; | ||
| var promise = $super.call(this, options); | ||
| this.fetchQueue && this.fetchQueue._promise = promise; |
There was a problem hiding this comment.
I think this is illegal. Even if it's not, its confusing.
Can you use the if form for this?
Also we should have a comment as to why we are doing this so people aren't confused about it in the future.
There was a problem hiding this comment.
will do. I referenced the issue in the commit so people would see it on a blame but I'll a comment as well.
|
Released in 2.3.1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
null check to address #304