Skip to content
This repository has been archived by the owner on Mar 20, 2021. It is now read-only.

IE11 fails 2 view helper tests #298

Closed
solidgoldpig opened this issue Jan 7, 2014 · 1 comment
Closed

IE11 fails 2 view helper tests #298

solidgoldpig opened this issue Jan 7, 2014 · 1 comment

Comments

@solidgoldpig
Copy link
Contributor

IE11 fails the following tests:

view helper

  • child views within #each
expected 'a\r\n\r\nb' to equal 'ab'
  • child views within #each with mutation
expected 'a\r\n\r\nb\r\n\r\nc' to equal 'abc'
solidgoldpig added a commit to solidgoldpig/thorax that referenced this issue Jan 7, 2014
@solidgoldpig
Fix for IE11 viewHelper test failures - issue walmartlabs#298
7870d4f 
Simply (naively?) stripping the line breaks from the output to be compared.
solidgoldpig added a commit to solidgoldpig/thorax that referenced this issue Jan 7, 2014
@solidgoldpig
Revert "Fix for IE11 viewHelper test failures - issue walmartlabs#298"
0e47938 
This reverts commit 7870d4f.
solidgoldpig added a commit to solidgoldpig/thorax that referenced this issue Jan 7, 2014
@solidgoldpig
Fix for IE11 viewHelper test failures - issue walmartlabs#298
02cc345
@kpdecker
Copy link
Contributor

Released in 2.3.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@solidgoldpig @kpdecker