Docs on helpers incomplete

[mulderp]

Hi!

Just a small note that the (new ?) docs on the helpers are incomplete:

http://walmartlabs.github.io/thorax-docs/helpers.html

in the URL, there should probably be {{url "article/{{url}}" expand-tokens=true}}

PS - would you accept a PR for this? where would I find the docs?

[alexlande]

Those are in fact very old docs. @eastridge: probably want to delete the gh-pages branch of the thorax-docs repo.

[eriktrom]

@alexlande nice catch, thanks for clarifying

@mulderp new docs for http://walmartlabs.github.io/thorax-docs/helpers.html can be found at http://thoraxjs.org/api.html#template-helpers (i'm sure you found it by now though)

@eastridge - delete https://github.com/walmartlabs/thorax-docs/tree/gh-pages real quick, it's way old... if there is stuff there you want to keep, let me know, i can pull it over (also keep in mind redirecting)

also, if someone is interested in making doc changes, should they submit a PR to thorax or thorax-docs?

[alexlande]

Submit doc PRs to thorax. thorax-docs pulls in content from the Thorax README through a grunt task (this setup is going to change to something a bit cleaner sometime in the future though).

[eriktrom]

awesome, thankyou @alexlande

[mulderp]

Thanks for the clarifications, works great!

[eastridge]

Deleted the gh-pages branch thanks everyone for catching this

On Sun, Dec 8, 2013 at 2:05 AM, Patrick Mulder [email protected]:

Closed #274 #274.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/274
.