Pull in fixes from v5.23.5 #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…snag#442) write(2) already intelligently handles buffering/writing, so this buffer is unneeded in addition to being unsafe for the user-initiated reporting case. The buffer was added in kstenerud/KSCrash@be9bedb and thus the original intent is lost to the mists.
On a Mac: git ls-files -ci --exclude-standard -z | xargs -0 git rm --cached (from https://stackoverflow.com/a/7532131/2431627)
… if returning to the foreground after more than 60 seconds
…vents-foreground-background (fix) Automatic session reporting now correctly records a new session…
…branch for installation tests
…note to PR template
Release v5.23.2
Clarify and expand the CONTRIBUTING.md notes
Co-authored-by: Robin Macharg <[email protected]>
Reduces complexity of PR template as discussed in retro
…sm at runtime, not compile-time
Fix DYLD lock mechanism preventing compilation on iOS <10
V5 backports
Release v5.23.4
Release v5.23.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Bring in all changes along the v5 branch of Official Upstream Bugsnag. (including fixes required for building with Xcode 12.
Fixes: Not being able to build with Xcode 12.
Changeset
I created this branch by fetching from upstream then resetting hard to the commit which tag v5.23.5 points to.
i.e. bugsnag@c64b617
Tests
I have not tested this at all. Full faith in the Bugsnag devs and community.
Review
Outstanding Questions
Once this is merged into https://github.com/walmartlabs-wmusiphone/bugsnag-cocoa.git we can re-tag as
v5.23.5-walmartand point our cartfile at this to continue our Xcode 12 migration.