Fixed statusbar error when focusing to webview

[martonsagi]

Hi Waldo,

I have seen that your extension is subscribed to vscode.workspace.onDidOpenTextDocument event. This subscription causes errors when there is no active TextEditor.

1. A Webview is focused

First case is no big issue as it happens rarely, but still it should be fixed. :)

2. No open document

Second case, however, can easily become a real performance-killer when another extension decides to read up all AL files via VSCode api, thus emitting onDidOpenTextDocument event like 6000 times for a BaseApp.

The fix

My proposed solution would be to move your statusbar update code from workspace.onDidOpenTextDocument to window.onDidChangeActiveTextEditor with some additional error checks to avoid unexpected exceptions.

It would be a big help for me, as AL Studio is currently crashing during activation phase when AL XML Documentation is present, indirectly overloading VSCode by an event subscription in your extension. Simple times indeed :)

Thanks,
Marton

[waldo1001]

thank you so much! I will merge these in asap!

[martonsagi]

Thank you! In the meantime, I have also added a pull request to AL XML Doc in order to get to the bottom of the root cause as well. :)
365businessdev/vscode-alxmldocumentation#34