Renaming doesn't remove underscore

[CNAEvidi]

With AL 5 underscore in filenames are no longer allowed

Can you modify navobject.ts line 264+265 to
this.objectName = this.objectName.trim().toString().replace(/["]/g, '');
this.extendedObjectName = this.extendedObjectName.trim().toString().replace(/["]/g, '');

Regards
Christoffer

[waldo1001]

I think you meant:

this.objectName = this.objectName.trim().toString().replace(/["_]/g, '');
this.extendedObjectName = this.extendedObjectName.trim().toString().replace(/["_]/g, '');

I was a bit confused, but the "_" got removed from your message :-).

[CNAEvidi]

Seems right important thing is to remove the underscore when renaming man. 27. apr. 2020 15.55 skrev waldo <[email protected]>:

…

I think you meant: this.objectName = this.objectName.trim().toString().replace(/["_]/g, ''); this.extendedObjectName = this.extendedObjectName.trim().toString().replace(/["_]/g, ''); I was a bit confused, but the "_" got removed from your message :-). — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#161 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKA3V7WBSMHFH7NA5QMC563ROWFEPANCNFSM4MDD4RNA> .

[benjaminknapper]

I am unable to find documentation that outlines underscore as a forbidden character in AL file names.
Currently CRS v1.2.2 seems to me to operate in an interesting fashion as listed below.

I have extensions:
AL Language v5.0.254558
waldo's CRS AL Language Extension v1.2.2

Settings:
CRS: Object Name Prefix = XX_
CRS: On Save Al File Action = Rename

Original file name:
Pag46-Ext50131.XX_SalesOrderSubform.al

New file name upon saving:
Pag46-Ext50131.XX_XXSalesOrderSubform.al

Object header:
pageextension 50131 "XX_SalesOrderSubform" extends "Sales Order Subform" //46

So my two questions are:

1. @CNAPilaro or @waldo1001 can you point me towards the documentation that outlines underscore as a forbidden character in AL file names? I want to be able to justify the work this will require to remove the underscores we have appended as our prefix.
2. Regardless of the validity of the underscore character in files names. @waldo1001 is the above the desired effect of the rename function for files that already exist and have been using your extension?

[waldo1001]

it is not the desired effect - just a consequence of me removing underscores.
I'm doing a build now that fixes it, and that introduces a setting where you can control it however you want.

about documentation: I haven't. but the Code Analysis indicate it

[benjaminknapper]

I appreciate the speedy response. I also wanted to note that after I posted my comment I found Issue #169 and wanted to put that here!

You're the best!