Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Google Java Format 1.24.0 #1433

Merged
merged 3 commits into from
Oct 4, 2024
Merged

Conversation

msridhar
Copy link
Member

There are some minor formatting changes with switch statements. Also remove the old GJF plugin from libs.version.toml as we now use Spotless.

@msridhar msridhar requested a review from liblit July 31, 2024 14:22
@msridhar msridhar enabled auto-merge (squash) July 31, 2024 14:22
liblit
liblit previously approved these changes Jul 31, 2024
Copy link

github-actions bot commented Jul 31, 2024

Test Results

  813 files  ±0    813 suites  ±0   4h 12m 1s ⏱️ + 3m 16s
  735 tests ±0    718 ✅ ±0   17 💤 ±0  0 ❌ ±0 
5 029 runs  ±0  4 908 ✅ ±0  121 💤 ±0  0 ❌ ±0 

Results for commit e0cc467. ± Comparison against base commit 999faf5.

♻️ This comment has been updated with latest results.

@msridhar msridhar disabled auto-merge July 31, 2024 15:23
@msridhar
Copy link
Member Author

Going to hold off on merging this for now due to google/google-java-format#1127.

@msridhar msridhar changed the title Update to Google Java Format 1.23.0 Update to Google Java Format 1.24.0 Oct 4, 2024
@msridhar msridhar enabled auto-merge (squash) October 4, 2024 17:43
@msridhar msridhar requested a review from liblit October 4, 2024 17:43
@msridhar
Copy link
Member Author

msridhar commented Oct 4, 2024

@liblit can you review again? This should work now with GJF 1.24.0

@msridhar msridhar merged commit 904a3a4 into wala:master Oct 4, 2024
11 checks passed
@msridhar msridhar deleted the update-gjf branch October 4, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants