Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NPE in EclipseSourceFileModule ctor #1261

Merged
merged 2 commits into from
Apr 11, 2023
Merged

Conversation

khatchad
Copy link
Contributor

@khatchad khatchad commented Apr 10, 2023

The getLocation() API is returning null, resulting in an NPE. Use getFullPath() instead, which seems to work.

The `getLocation()` API is returning `null`, resulting in an NPE. Use `getFullPath()` instead, which seems to work.
Copy link
Member

@msridhar msridhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would normally ask for a test for this, but don't think that will be easy, so we can go ahead and land

@msridhar msridhar merged commit d15ca9b into wala:master Apr 11, 2023
khatchad added a commit to ponder-lab/WALA that referenced this pull request Apr 11, 2023
* Fix NPE in EclipseSourceFileModule ctor

The `getLocation()` API is returning `null`, resulting in an NPE. Use `getFullPath()` instead, which seems to work.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants