-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: libwaku - extending the library with peer_manager and peer_exchange features #3026
Conversation
You can find the image built from this PR at
Built from 3c9680e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you! Just added a small question :))
WAKU_CALL( waku_get_peerids_from_peerstore(ctx, | ||
event_handler, | ||
userData) ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this call?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thank you!
Left some comments.
library/waku_thread/inter_thread_communication/requests/peer_manager_request.nim
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!!!!
Description
One more step towards exposing nwaku through libwaku. The exposed features are currently needed by status-go.
Notice that there will be more upcoming features soon.
Changes
Adding new features: