Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: libwaku - extending the library with peer_manager and peer_exchange features #3026

Merged
merged 4 commits into from
Sep 11, 2024

Conversation

Ivansete-status
Copy link
Collaborator

Description

One more step towards exposing nwaku through libwaku. The exposed features are currently needed by status-go.
Notice that there will be more upcoming features soon.

Changes

Adding new features:

  • waku_get_peerids_from_peerstore
  • waku_get_peerids_by_protocol
  • waku_peer_exchange_request

@Ivansete-status Ivansete-status changed the title libwaku: extending the library with peer_manager and peer_exchange features chore: libwaku - extending the library with peer_manager and peer_exchange features Sep 9, 2024
Copy link

github-actions bot commented Sep 9, 2024

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:3026

Built from 3c9680e

@Ivansete-status Ivansete-status marked this pull request as ready for review September 9, 2024 08:35
Copy link
Contributor

@gabrielmer gabrielmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you! Just added a small question :))

Comment on lines +329 to +331
WAKU_CALL( waku_get_peerids_from_peerstore(ctx,
event_handler,
userData) );
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this call?

Copy link
Contributor

@SionoiS SionoiS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thank you!

Left some comments.

library/libwaku.nim Show resolved Hide resolved
Copy link
Contributor

@NagyZoltanPeter NagyZoltanPeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!!!

@Ivansete-status Ivansete-status merged commit 5ea1cf0 into master Sep 11, 2024
9 of 11 checks passed
@Ivansete-status Ivansete-status deleted the extend-libwaku branch September 11, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants