Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update waku-fleet-dashboard from latest (v142) Grafana + bw per shard + req/resp req rate and traffic metrics #3025

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

NagyZoltanPeter
Copy link
Contributor

Description

Noticed that our grafana dashoard (https://grafana.infra.status.im/) is diverged from our nwaku repository a lot while there is no real git/vcs friendly comparison possibility for it to decide about changes.
So while adding Bandwidth per shards, req/resp protocol request rates and traffic metrics I made a copy from grafana's v142 of fleets Nim-Waku V2

Changes

Contains all up to date changes had been made to https://grafana.infra.status.im +

Added panels:

  • per shard in(gross/net) and out traffic
  • store: request rate, generated in/out traffic
  • filter: request rate, generated message push (out) traffic of all subs
  • lightpush: request rate, inbound traffic for lightush (output appears in relay)

Removed row and panels:

  • legacy filter as had been removed from nwaku for a long time.

Although these panels were already added into nwaku - repository - metrics/waku-fleet-dashboard.json it was not updated into our grafana server.

image

image

image

image

@NagyZoltanPeter NagyZoltanPeter self-assigned this Sep 8, 2024
@NagyZoltanPeter NagyZoltanPeter changed the title Update waku-fleet-dashboard from latest (v142) Grafana + bw per shard + req/resp req rate and traffic metrics chore: Update waku-fleet-dashboard from latest (v142) Grafana + bw per shard + req/resp req rate and traffic metrics Sep 8, 2024
Copy link
Collaborator

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for it! 💯

To understang it better, did you copy the grafana dashboard that is currently deployed in https://grafana.infra.status.im/ and then applied the changes over it?

Copy link
Contributor

@gabrielmer gabrielmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@NagyZoltanPeter NagyZoltanPeter merged commit 780ebf3 into master Sep 10, 2024
11 of 12 checks passed
@NagyZoltanPeter NagyZoltanPeter deleted the chore-fleet-nwaku-dashboard-update branch September 10, 2024 08:02
@fryorcraken
Copy link
Collaborator

In those graph, is it possible to display the threshold, as configured on the deployed node?

@NagyZoltanPeter
Copy link
Contributor Author

In those graph, is it possible to display the threshold, as configured on the deployed node?

Yes I think I can add it as a separate gauge metric and show it as a dashed line.
What needs to be considered that fleet dashboards combine instances into a single panel, which can look very dense and disturbing for such amount of different values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants