Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Distinction between gross/net trafic in bandwidth per shard metric, a… #2920

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

NagyZoltanPeter
Copy link
Contributor

...added bandwidths and request rate panels to single node and fleet dashboards

Description

This was a leftover task after @Ivansete-status comments on #2851
Now gross and net traffic of incoming per shard relay measured separately.
Gross traffic means all incoming relay traffic (measured before validation). It will help us to understand how much of the bandwidth stress on the node vs. useful relay traffic that is actually valid and propagated forward. This is now measured per shard.

Changes

  • Introduced new counter filter of "type" for waku_relay_network_bytes metric, that represents distinction of gross/net traffic
  • In connection to feat: Added proper per shard bandwidth metric calculation #2851 I pulled and adjusted metrics panels to single node and fleet dashboards.
    • Added waku relay traffic per shads in/out
    • Added request rate, non relay traffic in/out separately in respective rows of store, filter and lightpush

Unfortunately, I cannot create pictures of working dashboards as it is not simple to try out the changes on fleet dashboard.

Issue

#1945

Connected PR

nwaku-compose respective changes: waku-org/nwaku-compose#99

Copy link

github-actions bot commented Jul 19, 2024

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2920

Built from 70def48

Copy link
Contributor

@gabrielmer gabrielmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Could you please add a screenshot of the new dashboard?

@NagyZoltanPeter
Copy link
Contributor Author

Thank you! Could you please add a screenshot of the new dashboard?

@gabrielmer : Actually these dashboards, specially the fleet one needs special environment.
But if you have an idea how to run grafana that way to show meaningful data on those panels... I will be thankful.

@gabrielmer
Copy link
Contributor

@gabrielmer : Actually these dashboards, specially the fleet one needs special environment. But if you have an idea how to run grafana that way to show meaningful data on those panels... I will be thankful.

Not sure I understand then, so how did these files get generated? I thought you created the dashboards in Grafana and update the files with the ones of the dashboard you built

@NagyZoltanPeter
Copy link
Contributor Author

@gabrielmer : Actually these dashboards, specially the fleet one needs special environment. But if you have an idea how to run grafana that way to show meaningful data on those panels... I will be thankful.

Not sure I understand then, so how did these files get generated? I thought you created the dashboards in Grafana and update the files with the ones of the dashboard you built

Well I was using nwaku-compose, I put them there, but prometheus under nwaku-compose do not provide the right collection to populate the dashboard with data. Like for fleet we have datacenter, node type and other distinctions, but for that you would need to setup properly the whole, which I did not. I was copying from nwaku-compose's dashboard the panels and adapt the queries. Kinda' hack.

@gabrielmer
Copy link
Contributor

Well I was using nwaku-compose, I put them there, but prometheus under nwaku-compose do not provide the right collection to populate the dashboard with data. Like for fleet we have datacenter, node type and other distinctions, but for that you would need to setup properly the whole, which I did not. I was copying from nwaku-compose's dashboard the panels and adapt the queries. Kinda' hack.

Got it! Yeah I'm also not sure how/where these panels are supposed to be run, I didn't know they existed.

@Ivansete-status do you know where are they used and how they can be tested? Are they specifically for https://grafana.infra.status.im/ ?

Copy link
Collaborator

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for it! 💯
If possible it'd help to have screenshot of new panels.
I wonder though how can we deploy the new dashboards into the fleet's Grafana

@gabrielmer gabrielmer self-requested a review August 6, 2024 08:38
Copy link
Contributor

@gabrielmer gabrielmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving also not to block with the monitoring part :)) Thank you!

…dded bandwidths and request rate panels to single node and fleet dashboards
@NagyZoltanPeter NagyZoltanPeter force-pushed the chore-add-gross-net-shard-traffic-metric branch from e53da75 to 349624b Compare August 21, 2024 13:26
@NagyZoltanPeter NagyZoltanPeter merged commit c7093d7 into master Aug 21, 2024
9 of 11 checks passed
@NagyZoltanPeter NagyZoltanPeter deleted the chore-add-gross-net-shard-traffic-metric branch August 21, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants