-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Distinction between gross/net trafic in bandwidth per shard metric, a… #2920
chore: Distinction between gross/net trafic in bandwidth per shard metric, a… #2920
Conversation
You can find the image built from this PR at
Built from 70def48 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Could you please add a screenshot of the new dashboard?
@gabrielmer : Actually these dashboards, specially the fleet one needs special environment. |
Not sure I understand then, so how did these files get generated? I thought you created the dashboards in Grafana and update the files with the ones of the dashboard you built |
Well I was using nwaku-compose, I put them there, but prometheus under nwaku-compose do not provide the right collection to populate the dashboard with data. Like for fleet we have datacenter, node type and other distinctions, but for that you would need to setup properly the whole, which I did not. I was copying from nwaku-compose's dashboard the panels and adapt the queries. Kinda' hack. |
Got it! Yeah I'm also not sure how/where these panels are supposed to be run, I didn't know they existed. @Ivansete-status do you know where are they used and how they can be tested? Are they specifically for https://grafana.infra.status.im/ ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for it! 💯
If possible it'd help to have screenshot of new panels.
I wonder though how can we deploy the new dashboards into the fleet's Grafana
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving also not to block with the monitoring part :)) Thank you!
…dded bandwidths and request rate panels to single node and fleet dashboards
e53da75
to
349624b
Compare
...added bandwidths and request rate panels to single node and fleet dashboards
Description
This was a leftover task after @Ivansete-status comments on #2851
Now gross and net traffic of incoming per shard relay measured separately.
Gross traffic means all incoming relay traffic (measured before validation). It will help us to understand how much of the bandwidth stress on the node vs. useful relay traffic that is actually valid and propagated forward. This is now measured per shard.
Changes
waku relay traffic per shads in/out
request rate
,non relay traffic in/out
separately in respective rows of store, filter and lightpushUnfortunately, I cannot create pictures of working dashboards as it is not simple to try out the changes on fleet dashboard.
Issue
#1945
Connected PR
nwaku-compose respective changes: waku-org/nwaku-compose#99