Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: simple library cleanup of unused imports and duplicated code #2710

Merged
merged 1 commit into from
May 18, 2024

Conversation

Ivansete-status
Copy link
Collaborator

Description

Simple cleanup to remove unused imports and duplicated code in library/waku_thread/inter_thread_communication/requests/node_lifecycle_request.nim

Copy link

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2710-rln-v2

Built from f85f5c4

Copy link

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2710-rln-v1

Built from f85f5c4

@Ivansete-status Ivansete-status marked this pull request as ready for review May 17, 2024 13:22
Copy link
Contributor

@gabrielmer gabrielmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Contributor

@NagyZoltanPeter NagyZoltanPeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great one!!!

@Ivansete-status Ivansete-status merged commit 5ee4cba into master May 18, 2024
15 of 16 checks passed
@Ivansete-status Ivansete-status deleted the libwaku-cleanup branch May 18, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants