Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update CHANGELOG.md for v0.24.0 #2347

Merged
merged 4 commits into from
Jan 12, 2024
Merged

chore: update CHANGELOG.md for v0.24.0 #2347

merged 4 commits into from
Jan 12, 2024

Conversation

SionoiS
Copy link
Contributor

@SionoiS SionoiS commented Jan 10, 2024

Update CHANGELOG.md for v0.24.0

My first release. Yeah! One thing of note, for this release is #2305

I also had to create the notes manually because make release-notes for me returns failed to discovery repository top level, error: exit status 128 - fatal: detected dubious ownership in repository at '/opt/sv4git/repo'

Tracking #2343

@SionoiS SionoiS added the release Tracks releases label Jan 10, 2024
@SionoiS SionoiS self-assigned this Jan 10, 2024
Copy link
Contributor

@jm-clius jm-clius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Added a couple of minor observations.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for it! 💯
Maybe I'm missing it but I think we should also mention the following in the "Changes" section:
image

( I checked v0.23.1...master )

CHANGELOG.md Show resolved Hide resolved
@SionoiS
Copy link
Contributor Author

SionoiS commented Jan 10, 2024

LGTM! Thanks for it! 💯
Maybe I'm missing it but I think we should also mention the following in the "Changes" section:
image

Was that not part of 0.23? I'll verify!

edit: Indeed I'm missing a couple of commits.

@SionoiS SionoiS requested a review from vpavlin January 10, 2024 16:41
@SionoiS SionoiS changed the base branch from release/v0.24 to master January 10, 2024 16:48
Copy link
Contributor

@gabrielmer gabrielmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks so much!

CHANGELOG.md Show resolved Hide resolved
@SionoiS SionoiS merged commit 988580e into master Jan 12, 2024
8 checks passed
@SionoiS SionoiS deleted the releasenotes24 branch January 12, 2024 12:30
@SionoiS SionoiS restored the releasenotes24 branch January 12, 2024 12:31
@SionoiS SionoiS deleted the releasenotes24 branch January 12, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Tracks releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants