Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rln-relay): missed roots during sync #2013

Closed
wants to merge 1 commit into from

Conversation

rymnc
Copy link
Contributor

@rymnc rymnc commented Sep 7, 2023

Description

on a new block header, processes min(g.latestProcessedBlock, newHeadNumber) to account for missed blocks

Changes

  • newBlockHeader processing strategy

Issue

closes #2002

@rymnc rymnc self-assigned this Sep 7, 2023
@github-actions
Copy link

github-actions bot commented Sep 7, 2023

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2013

@github-actions
Copy link

github-actions bot commented Sep 7, 2023

You can find the experimental image built from this PR at

quay.io/wakuorg/nwaku-pr:2013-experimental

@rymnc rymnc force-pushed the investigation-invalid-root-2 branch from 71bdb51 to b9e1783 Compare September 7, 2023 13:48
@rymnc rymnc changed the title test(rln-relay): investigation of invalid roots fix(rln-relay): missed roots during sync Sep 7, 2023
@rymnc rymnc marked this pull request as ready for review September 7, 2023 13:50
Copy link
Contributor

@alrevuelta alrevuelta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@rymnc rymnc force-pushed the investigation-invalid-root-2 branch from b9e1783 to f3e757c Compare September 7, 2023 22:09
@rymnc rymnc force-pushed the investigation-invalid-root-2 branch from f3e757c to b4d082d Compare September 8, 2023 06:41
@rymnc rymnc closed this Sep 8, 2023
@rymnc rymnc deleted the investigation-invalid-root-2 branch September 8, 2023 06:52
@rymnc rymnc restored the investigation-invalid-root-2 branch September 8, 2023 06:53
@rymnc rymnc deleted the investigation-invalid-root-2 branch September 8, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

bug(rln): problems syncing the rln tree, different roots
2 participants