Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(common): extend base64 test coverage #1583

Merged
merged 1 commit into from
Mar 1, 2023
Merged

Conversation

LNSD
Copy link
Contributor

@LNSD LNSD commented Feb 28, 2023

Based on @alrevuelta's comment, I have extended the test coverage for the base64 common module.

This PR rules out the base64 encoding/decoding functions from the equation. The issue could be in the JSON-RPC parsing itself. A deeper investigation is necessary.

  • Added all the RFC test vectors to the test suite.
  • Added additional test cases covering the comment's test vector.
  • Turned the test suite into a data-driven test suite.

@LNSD LNSD requested review from alrevuelta and jm-clius February 28, 2023 15:10
@LNSD LNSD self-assigned this Feb 28, 2023
@LNSD LNSD merged commit 4066b74 into master Mar 1, 2023
@LNSD LNSD deleted the tests-extend-base64-tests branch March 1, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants