-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: release v0.14.0 #1488
docs: release v0.14.0 #1488
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✅🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! just a non-blocking opinion in case you want to revisit this.
|
||
### Features | ||
|
||
- Support for [AutoNAT](https://docs.libp2p.io/concepts/nat/autonat/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a preference, but like having a link to the PR to see the changes (like in the fixes section)
Not sure if you could try the autogenerated notes. With good PR namings it makes creating the release notes quite easy :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I do use the autogenerated notes as starting point, but find that to make it humanly interpretable requires significant rewrite (e.g. many "features" and "fixes" just fall under a "updated submodules"). It was a bit easier to rewrite and keep links to PRs related to fixes. I think this is the way to go in the future when we have automated releases, but we may need to revisit how commit messages are formatted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, not suggesting to use the autogenerated notes by default. +1 for human readable.
my only concern was to link the PR of each feature :)
- Zerokit RLN library now statically linked. | ||
- Use extended key generation in Zerokit API to comply with [32/RLN](https://rfc.vac.dev/spec/32/). | ||
- Re-enable root validation in [`17/WAKU-RLN-RELAY`](https://rfc.vac.dev/spec/17/) implementation. | ||
- [Network monitoring tool](https://github.com/status-im/nwaku/tree/2336522d7f478337237a5a4ec8c5702fb4babc7d/tools#networkmonitor) now supports DNS discovery. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a preference.
Network monitoring tool now supports DNS discovery. #1446
- Simplified project Makefile. | ||
- Split Dockerfile into production and experimental stages. | ||
- Removed obsolete simulation libraries from build. | ||
- Improved parallellisation (and therefore processing time) when dialing several peers simultaneously. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Improved parallellisation (and therefore processing time) when dialing several peers simultaneously. #1471
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks!
1bc340a
to
c0da7f4
Compare
Adds the release notes for Release v0.14.0
I believe everything necessary for the release has been merged already. I will do a last sanity check before merging this PR to close the last open issues.
For the items you were responsible for, please check: