-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add editorconfig file #1403
Conversation
I assume this involves installing an extension and loading this config file? like "EditorConfig for VS Code"? Should we document this somewhere? |
# Trailing spaces in markdown indicate word wrap | ||
[{*.markdown,*.md}] | ||
trim_trailing_spaces = false | ||
max_line_length = 80 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the effect of this max_line_length
? Will longer lines be auto-wrapped?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is from the editorconfig's default values. I just copied it here, so we don't have any surprises with implicit configurations.
What is the effect of this
max_line_length
? Will longer lines be auto-wrapped?
VS code only supports a small subset of editorconfig parameters: https://marketplace.visualstudio.com/items?itemName=EditorConfig.EditorConfig#supported-properties
So the answer is: no, it is not supported by the vscode/plugin; no effect.
I thought VS Code was already shipped with the editorconfig extension installed by default. Given that you are the one that joined most recently, and I am very busy with the Waku store investigation, @alrevuelta can you document it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Happy with this, but I assume it's Visual Studio-specific? Since some contributors use other editors (e.g. vim), we can perhaps just provide them with style guidelines.
In that case, they'll have to install the |
This PR addresses a long-existing concern: trailing whitespaces.
.editorconfig
file for editor configuration homogeneity. Configure to remove the trailing whitespaces automatically.Every time a file is modified, the trailing whitespaces will be removed. This will allow us to follow an incremental approach toward a cleaner codebase.