fix(lightpush): waku lightpush rpc codec support optional fields #1395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LNSD
force-pushed
the
fix-lightpush-rpc
branch
from
e100db0 to
572243b
Compare
|
macOS test2 job failing due to the same offending test case.. Test failure already tracked in #1357. Merging without re-running the checks and Ubuntu test2 job is passing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To follow the Waku lightpush
2.0.0-beta1protobuf definition:Option[T]types when the field is optional.This is a dependency of the Make
waku_message.nimcomply with the protobuf definition task.