Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade nim-stew to latest version #1366

Merged
merged 3 commits into from
Nov 10, 2022
Merged

Conversation

LNSD
Copy link
Contributor

@LNSD LNSD commented Nov 9, 2022

After merging the warning fix into nim-stew, status-im/nim-stew#147, the version can be upgraded to the latest version.

In nwaku we have been using nim 1.6 for some time. This fixes the following deprecation warning:

/nwaku/vendor/nim-stew/stew/sorted_set/rbtree_desc.nim(197, 30) Warning: Deprecated since v1.4; there should not be `high(value)`. Use `high(type)`.; high is deprecated [Deprecated]

@LNSD LNSD self-assigned this Nov 9, 2022
@LNSD LNSD requested a review from jm-clius November 9, 2022 17:13
@LNSD LNSD force-pushed the chore-upgrade-nim-stew branch from 79e71e8 to 27f25d8 Compare November 9, 2022 17:13
@status-im-auto
Copy link
Collaborator

status-im-auto commented Nov 9, 2022

Jenkins Builds

Click to see older builds (4)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 27f25d8 #2 2022-11-09 17:30:59 ~16 min macos 📦bin
✔️ 27f25d8 #2 2022-11-09 17:35:44 ~21 min linux 📦bin
✔️ 79e71e8 #1 2022-11-09 17:34:00 ~20 min macos 📦bin
✔️ 79e71e8 #1 2022-11-09 17:35:16 ~22 min linux 📦bin
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ adf50b7 #3 2022-11-09 18:07:37 ~16 min linux 📦bin
✔️ adf50b7 #3 2022-11-09 18:08:05 ~16 min macos 📦bin
✔️ 0e71e4f #4 2022-11-09 19:23:07 ~14 min linux 📦bin
✔️ 0e71e4f #4 2022-11-09 19:23:36 ~15 min macos 📦bin

@LNSD LNSD merged commit 47fe697 into master Nov 10, 2022
@LNSD LNSD deleted the chore-upgrade-nim-stew branch November 10, 2022 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants