refactor: continue pubsub/content types started in #1352

[alrevuelta]

• Resolves comment1 from refactor: unify pubsub topic type and default value #1352
• Resolves comment2 from refactor: unify pubsub topic type and default value #1352

Summary:

• General refactor using PubsubTopic and ContentTopic fields.
• Reuse default values for both fields introduced in refactor: unify pubsub topic type and default value #1352
• Removes PubsubTopicString and its usages.
• Enforce defaultPubsubTopics instead of defaultTopics

As a general note, which I think @LNSD agrees with me, we should be specific using pubsub or content instead of just using topic. As it may be confusing.

[status-im-auto]

Jenkins Builds

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	c619c32	#1	2022-11-09 09:44:18	~14 min	macos	📦bin
✔️	c619c32	#1	2022-11-09 09:49:08	~19 min	linux	📦bin

[LNSD]

This is redundant and not necessary, the types are not distinct string

[alrevuelta]

yep, thought it was nice for reference, so that people declaring topics they would see this and follow the pattern:

let x = PubsubTopic("x/y/z/a")

instead of let y = "x/y/z/a" which I would say its bad practise?

no strong opinion about it, though :)

[LNSD]

It is redundant since the variable is already type annotated:

 DefaultPubsubTopic*: PubsubTopic = PubsubTopic("/waku/2/default-waku/proto")
 #~~~~~~~~~~~~~~~~~~~~~~~~~^

[LNSD]

LGTM ✅

[rymnc]

LGTM!

[jm-clius]

LGTM! Thanks.