Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: extend docs with the different node configuration mechanisms #1355

Merged
merged 5 commits into from
Nov 8, 2022

Conversation

LNSD
Copy link
Contributor

@LNSD LNSD commented Nov 8, 2022

I am not 100% sure if this is the right place (the correct markdown file) to provide these details. If you know a better place where to specify this information, do not hesitate to suggest it in the comments.

  • Extend operator's documentation with the different configuration methods supported by wakunode2

@LNSD LNSD self-assigned this Nov 8, 2022
@LNSD
Copy link
Contributor Author

LNSD commented Nov 8, 2022

@mfw78, it would be interesting to hear your opinion on this and if this covers your requirements hence #1198

@status-im-auto
Copy link
Collaborator

status-im-auto commented Nov 8, 2022

Jenkins Builds

Click to see older builds (6)
Commit #️⃣ Finished (UTC) Duration Platform Result
⁉️ 8b1a7eb #1 2022-11-08 12:54:46 ~5 min macos 📄log
⁉️ 8b1a7eb #1 2022-11-08 12:54:53 ~5 min linux 📄log
⁉️ 56d58a0 #4 2022-11-08 15:15:22 ~6 min linux 📄log
✔️ 56d58a0 #4 2022-11-08 15:36:51 ~27 min macos 📦bin
⁉️ bd3bbca #5 2022-11-08 15:17:13 ~5 min linux 📄log
⁉️ bd3bbca #5 2022-11-08 15:36:48 ~25 min macos 📄log
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ a95d7cf #2 2022-11-08 15:19:21 ~18 min linux 📦bin
✔️ a95d7cf #2 2022-11-08 15:20:36 ~20 min macos 📦bin
✔️ 691553a #3 2022-11-08 15:27:30 ~19 min linux 📦bin
✔️ 691553a #3 2022-11-08 15:29:06 ~20 min macos 📦bin

Copy link
Contributor

@alrevuelta alrevuelta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks for the PR! really relevant. left a minor comment.

docs/operators/how-to/configure.md Outdated Show resolved Hide resolved
Copy link

@mfw78 mfw78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great work on the configuration options! This fits perfectly with the issue that was raised 👍

Copy link
Contributor

@rymnc rymnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this looks like a good place to put it, maybe can go in its own how-to later

docs/operators/how-to/configure.md Outdated Show resolved Hide resolved
Copy link
Contributor

@alrevuelta alrevuelta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks for the example on the overrides: i.e. cli overrides env.

@LNSD LNSD merged commit 384abed into master Nov 8, 2022
@LNSD LNSD deleted the docs-operator-config branch November 8, 2022 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants