refactor(queue_store): rename queue_store module and simplify api #1348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LNSD
commented
Nov 7, 2022
| @@ -168,130 +168,6 @@ procSuite "Sorted store queue": | |||
| lastRes.isErr() | |||
| lastRes.error() == "Not found" | |||
|
|
|||
| test "Store queue pagination works with predicate - fwd direction": | |||
There was a problem hiding this comment.
Some of these test cases were overlapping with the ones in test_message_store_queue_pagination. Removed the duplicated ones, and added the rest of the pagination-related test cases to the other test suite.
4 tasks
|
I have re-run the failed check (macOS test2 job timed out again). If it does not pass this time, I will merge this PR. The failure cause is unrelated to this PR's changes. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of the REST API, c bindings, and Waku Store roadmaps. These changes are accessories and help to settle the bases to decouple the RPC types from the API types for the Waku Store protocol.
StoreQueueRefAPIStoreQueueReffrom the Waku Store RPC errorsMessageStore's "no methods without base" warning