-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(networkmonitor): add metric listing content topics + messages #1335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alrevuelta
force-pushed
the
monitor-topics
branch
from
November 3, 2022 11:07
ea4da67
to
6606476
Compare
Jenkins BuildsClick to see older builds (8)
|
alrevuelta
force-pushed
the
network-monitoring-tool
branch
3 times, most recently
from
November 7, 2022 15:48
dc6478b
to
4de12f2
Compare
alrevuelta
force-pushed
the
network-monitoring-tool
branch
2 times, most recently
from
November 10, 2022 07:16
27fcb37
to
725cd9f
Compare
alrevuelta
force-pushed
the
monitor-topics
branch
from
November 10, 2022 16:54
6606476
to
ed5b0b5
Compare
alrevuelta
force-pushed
the
monitor-topics
branch
from
November 11, 2022 08:53
dd43aa4
to
d23fa88
Compare
jm-clius
approved these changes
Nov 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff!
|
||
### metrics | ||
Metrics are divided into two categories: | ||
* Prometheus metrics, exposed as i.e. gauges. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
* Prometheus metrics, exposed as i.e. gauges. | |
* Prometheus metrics, exposed as e.g. gauges. |
perhaps? :)
This was referenced Nov 14, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New feature for
networkmonitor
:DefaultPubsubTopic
and counts amount of messages rx in each content topichttp://127.0.0.1:8009/contenttopics
Notes:
Related #1010
Depends on #1290