Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(wakunode2): move configuration load logic to config module #1329

Merged
merged 1 commit into from
Nov 3, 2022
Merged

refactor(wakunode2): move configuration load logic to config module #1329

merged 1 commit into from
Nov 3, 2022

Conversation

LNSD
Copy link
Contributor

@LNSD LNSD commented Nov 2, 2022

In my road to support configuring wakunode2 via environment variables, I bring this gardening PR 🌳

  • Move the WakuNodeConf.load() to the config module
  • Make load() to return a ConfResult
  • Manage the --version option with confutils

@LNSD LNSD requested review from alrevuelta, rymnc and jm-clius November 2, 2022 16:46
@LNSD LNSD self-assigned this Nov 2, 2022
@status-im-auto
Copy link
Collaborator

status-im-auto commented Nov 2, 2022 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ 721cf52 #1 2022-11-02 16:56:00 ~9 min linux 📄log
❌ 721cf52 #1 2022-11-02 16:56:29 ~10 min macos 📄log
✔️ 73e27ac #2 2022-11-02 19:41:14 ~14 min linux 📦bin
✔️ 73e27ac #2 2022-11-02 19:42:46 ~16 min macos 📦bin

@LNSD LNSD mentioned this pull request Nov 2, 2022
Merged
3 tasks
@LNSD LNSD force-pushed the refactor-wakunode-config-load branch from 721cf52 to 73e27ac Compare November 2, 2022 19:26
rymnc
rymnc approved these changes Nov 3, 2022
View reviewed changes
Copy link
Contributor

@rymnc rymnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@LNSD LNSD merged commit e5a0c3d into master Nov 3, 2022
@LNSD LNSD deleted the refactor-wakunode-config-load branch November 3, 2022 09:45
@alrevuelta alrevuelta mentioned this pull request Nov 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rymnc rymnc rymnc approved these changes

@alrevuelta alrevuelta Awaiting requested review from alrevuelta

@jm-clius jm-clius Awaiting requested review from jm-clius

Assignees

@LNSD LNSD

Labels
None yet
Projects
Waku
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LNSD @status-im-auto @rymnc