refactor(sqlite): move migrations logic to sqlite common module

[LNSD]

As an intermediate step, I decided to do a minor cleanup before we take another decision about what to do with the SQLite migrations. I moved the logic to the waku/common module where SQLite database code was moved previously.

• Move migrations to common/sqlite module since this code is agnostic to any implementation.
• Update tests accordingly

[status-im-auto]

Jenkins Builds

Click to see older builds (2)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	92aac88	#1	2022-11-02 09:51:49	~17 min	macos	📦bin
❌	92aac88	#1	2022-11-02 09:57:10	~22 min	linux	📄log

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
❌	194f51c	#2	2022-11-02 09:56:24	~20 min	linux	📄log
✔️	194f51c	#2	2022-11-02 09:58:39	~22 min	macos	📦bin
✔️	475839c	#3	2022-11-02 10:30:18	~16 min	macos	📦bin
✔️	475839c	#3	2022-11-02 10:31:49	~17 min	linux	📦bin

[rymnc]

LGTM!

[jm-clius]

LGTM

[jm-clius]

Thanks for starting to add these. Can you see any (good) reason for us to rather use:

when (NimMajor, NimMinor) < (1, 4):
  {.push raises: [Defect].}
else:
  {.push raises: [].}

?

Perhaps if someone compiles nwaku into a system with an older nim version (unlikely and should probably not be allowed) or (perhaps more likely) that the nimbus-build-system gets downgraded due to some unforeseen issues?

[LNSD]

I removed the Defect because the compiler added extra noise because of that pragma. I did it as an experiment, and I forgot to restore it.

Perhaps if someone compiles nwaku into a system with an older nim version (unlikely and should probably not be allowed) or (perhaps more likely) that the nimbus-build-system gets downgraded due to some unforeseen issues?

Absolutely! Let's do this in a unique PR where we change all the occurrences. WDYT? 🤔

[jm-clius]

Yeah, absolutely. This can be merged as is IMO. For me there is the more general questions on why we would want to keep the modules compatible with Nim <1.4, but that is a separate discussion and cost is low in any case.