Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(peer-exchange): move peer management to waku_node module #1320

Merged
merged 1 commit into from
Nov 2, 2022
Merged

refactor(peer-exchange): move peer management to waku_node module #1320

merged 1 commit into from
Nov 2, 2022

Conversation

LNSD
Copy link
Contributor

@LNSD LNSD commented Oct 31, 2022

For consistency with the other protocols:

  • Move set peer logic to waku node
  • Move peer exchange nodes metric to waku node module
  • Uniformize the first argument name in protocol.nim
  • Remove the unnecessary client module
  • Update tests accordingly

@LNSD LNSD requested review from kaiserd and jm-clius October 31, 2022 13:03
@LNSD LNSD self-assigned this Oct 31, 2022
@status-im-auto
Copy link
Collaborator

status-im-auto commented Oct 31, 2022 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ a56bd69 #1 2022-10-31 13:20:09 ~16 min macos 📦bin
✔️ a56bd69 #1 2022-10-31 13:21:07 ~17 min linux 📦bin
❌ 3aa3856 #2 2022-11-01 10:11:00 ~18 min macos 📄log
❌ 3aa3856 #2 2022-11-01 10:11:01 ~18 min linux 📄log
❌ 3aa3856 #3 2022-11-01 10:32:08 ~18 min linux 📄log
✔️ 3aa3856 #3 2022-11-01 10:33:03 ~19 min macos 📦bin
❌ 3aa3856 #4 2022-11-01 10:55:31 ~19 min linux 📄log
✔️ 3aa3856 #5 2022-11-01 11:37:45 ~16 min linux 📦bin

kaiserd
kaiserd approved these changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@kaiserd kaiserd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LNSD LNSD merged commit 1c46b61 into master Nov 2, 2022
@LNSD LNSD deleted the refactor-px-api branch November 2, 2022 08:45
@alrevuelta alrevuelta mentioned this pull request Nov 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaiserd kaiserd kaiserd approved these changes

@jm-clius jm-clius Awaiting requested review from jm-clius

Assignees

@LNSD LNSD

Labels
None yet
Projects
Waku
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LNSD @status-im-auto @kaiserd