Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(node): waku node code reorganization #1303

Merged
merged 1 commit into from
Oct 27, 2022
Merged

chore(node): waku node code reorganization #1303

merged 1 commit into from
Oct 27, 2022

Conversation

LNSD
Copy link
Contributor

@LNSD LNSD commented Oct 27, 2022

This is a gardening PR 🌳🧑‍🌾

  • Rename the string type alias from the ambiguous Topic name to PubsubTopic
  • Reorganize waku_node module code. Collocate and group together related methods to improve code readability
  • Unify setPeer methods. Now support multiaddress strings and RemotePeerInfo type as input parameter

NOTE: These changes are necessary for the coming protocol client PRs

@LNSD LNSD requested review from alrevuelta, rymnc and jm-clius October 27, 2022 11:45
@LNSD LNSD self-assigned this Oct 27, 2022
@status-im-auto
Copy link
Collaborator

status-im-auto commented Oct 27, 2022 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 9ec6b4d #1 2022-10-27 12:02:32 ~16 min linux 📦bin
✔️ 9ec6b4d #1 2022-10-27 12:03:02 ~16 min macos 📦bin

jm-clius
jm-clius approved these changes Oct 27, 2022
View reviewed changes
Copy link
Contributor

@jm-clius jm-clius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We may want to consider starting to annotating the public API with a public pragma for docgen purposes, as proposed and implemented in nim-libp2p

@LNSD
Copy link
Contributor Author

LNSD commented Oct 27, 2022

Thanks! We may want to consider starting to annotating the public API with a public pragma for docgen purposes, as proposed and implemented in nim-libp2p

I like that 😁 Explicitness for the win!

@LNSD LNSD merged commit 0725da0 into master Oct 27, 2022
@LNSD LNSD deleted the chore-node-code-reorg branch October 27, 2022 15:29
@alrevuelta alrevuelta mentioned this pull request Nov 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jm-clius jm-clius jm-clius approved these changes

@alrevuelta alrevuelta Awaiting requested review from alrevuelta

@rymnc rymnc Awaiting requested review from rymnc

Assignees

@LNSD LNSD

Labels
None yet
Projects
Waku
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LNSD @status-im-auto @jm-clius