Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(wakunode2): add nwaku agent-string to switch #1302

Merged
merged 1 commit into from
Oct 28, 2022
Merged

feat(wakunode2): add nwaku agent-string to switch #1302

merged 1 commit into from
Oct 28, 2022

Conversation

alrevuelta
Copy link
Contributor

@alrevuelta alrevuelta commented Oct 27, 2022 •
edited
Loading

Closes #1242

Description:

  • Set nwaku as default libp2p UserAgent used by identify protocol.
  • This parameter can be changed with a CLI flag.
  • If the flag is not provided, the default libp2p value is used (the one we currently had)
  • Tests testing the change

@status-im-auto
Copy link
Collaborator

status-im-auto commented Oct 27, 2022 •
edited
Loading

Jenkins Builds

Click to see older builds (6)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 88c928d #1 2022-10-27 08:51:37 ~14 min macos 📦bin
✔️ 88c928d #1 2022-10-27 08:53:47 ~16 min linux 📦bin
✔️ d2436ed #2 2022-10-28 06:42:05 ~14 min linux 📦bin
✔️ d2436ed #2 2022-10-28 06:42:11 ~14 min macos 📦bin
✔️ 2f2e25a #3 2022-10-28 08:14:39 ~15 min linux 📦bin
❌ 2f2e25a #3 2022-10-28 08:17:04 ~17 min macos 📄log
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 37fa705 #4 2022-10-28 12:47:52 ~16 min linux 📦bin
❌ 37fa705 #4 2022-10-28 12:49:53 ~18 min macos 📄log
✔️ 0ca753b #5 2022-10-28 13:25:03 ~14 min macos 📦bin
✔️ 0ca753b #5 2022-10-28 13:26:00 ~15 min linux 📦bin

jm-clius
jm-clius approved these changes Oct 27, 2022
View reviewed changes
Copy link
Contributor

@jm-clius jm-clius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

kaiserd
kaiserd approved these changes Oct 27, 2022
View reviewed changes
Copy link
Contributor

@kaiserd kaiserd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
(Left one comment.)

tests/v2/test_wakunode.nim Show resolved Hide resolved
waku/v2/node/waku_node.nim Outdated Show resolved Hide resolved
This was referenced Oct 27, 2022
Merged
Closed
@alrevuelta alrevuelta force-pushed the add-agent-switch branch 3 times, most recently from 2f2e25a to 37fa705 Compare October 28, 2022 12:30
@alrevuelta alrevuelta mentioned this pull request Oct 28, 2022
Merged
@alrevuelta alrevuelta merged commit d479aac into master Oct 28, 2022
@alrevuelta alrevuelta deleted the add-agent-switch branch October 28, 2022 13:12
@alrevuelta alrevuelta mentioned this pull request Nov 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaiserd kaiserd kaiserd approved these changes

@jm-clius jm-clius jm-clius approved these changes

@LNSD LNSD Awaiting requested review from LNSD

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chore: add withAgentVersion to advertise waku version to other peers
4 participants
@alrevuelta @status-im-auto @kaiserd @jm-clius