Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: call runPeerExchangeDiscv5Loop #1297

Merged
merged 1 commit into from
Oct 25, 2022

Conversation

kaiserd
Copy link
Contributor

@kaiserd kaiserd commented Oct 25, 2022

This PR adds a call to runPeerExchangeDiscv5Loop in wakunode2.nim.
runPeerExchangeDiscv5Loop asynchronously fills the px peer list via discv5.
Thanks @richard-ramos for pointing this out :).

@kaiserd kaiserd requested review from LNSD and jm-clius October 25, 2022 08:16
@status-im-auto
Copy link
Collaborator

status-im-auto commented Oct 25, 2022

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ fd2930a #1 2022-10-25 08:33:36 ~17 min linux 📦bin
✔️ fd2930a #1 2022-10-25 08:34:25 ~17 min macos 📦bin

Copy link
Contributor

@LNSD LNSD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

Copy link
Contributor

@jm-clius jm-clius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@kaiserd kaiserd merged commit c99b0a4 into master Oct 25, 2022
@kaiserd kaiserd deleted the fix/call-runPeerExchangeDiscv5Loop branch October 25, 2022 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants