Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add docker and quickstart guides #1289

Merged
merged 1 commit into from
Oct 24, 2022
Merged

Conversation

jm-clius
Copy link
Contributor

Closes #1207.

Adds a basic guide for running nwaku in a Docker container.
I've also moved and extended some of the existing docs so that the quickstart page is truly a quickstart page for typical configurations (i.e. just copy and paste the commands).
The existing step-by-step quickstart is now an "overview" document.

@jm-clius jm-clius requested review from LNSD, alrevuelta and rymnc October 21, 2022 14:25
@status-im-auto
Copy link
Collaborator

status-im-auto commented Oct 21, 2022

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
⁉️ 3b36dc4 #1 2022-10-21 14:31:59 ~6 min linux 📄log
⁉️ 3b36dc4 #1 2022-10-21 14:37:18 ~11 min macos 📄log

Copy link
Contributor

@alrevuelta alrevuelta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! guess you are aware of statusteam/nim-waku:v0.12.0. Do we plan to switch to nwaku or we will leave it like that?

@jm-clius jm-clius merged commit 8f5363e into master Oct 24, 2022
@jm-clius jm-clius deleted the docs/add-docker-guide branch October 24, 2022 08:31
@jm-clius
Copy link
Contributor Author

nice! guess you are aware of statusteam/nim-waku:v0.12.0. Do we plan to switch to nwaku or we will leave it like that?

Indeed! There are still some old naming conventions which we'd like to change (also the wakunode2 binary) that may require some wider consultation.

@jm-clius
Copy link
Contributor Author

@rymnc @LNSD in a trigger-happy phase, I accidentally merged this without waiting for your reviews. :) Please still feel free to let me know your thoughts and I'll address in a follow-up.

Copy link
Contributor

@LNSD LNSD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: instruction manual for running nwaku in a docker
4 participants