Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(wakunode2): extract setup proc definitions from main section #1286

Merged
merged 1 commit into from
Oct 21, 2022

Conversation

LNSD
Copy link
Contributor

@LNSD LNSD commented Oct 20, 2022

Another gardening PR 🌳 Preparing the ground for improving the configuration management.

  • Move wakunode2 setup procs out of isMainModule section
  • Add try/catch clauses to the exception-raising procs and return a result
  • Turn setup methods using waitFor into {.async.}.

NOTE: As a rule of thumb, waitFor should be used in the outermost scope (in this case, main(), in the tests the asyncTest already performs the waitFor for us.

@LNSD LNSD requested review from alrevuelta and jm-clius October 20, 2022 18:32
@LNSD LNSD self-assigned this Oct 20, 2022
@status-im-auto
Copy link
Collaborator

status-im-auto commented Oct 20, 2022

Jenkins Builds

Click to see older builds (2)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 3a1276c #1 2022-10-20 18:49:05 ~16 min linux 📦bin
✔️ 3a1276c #1 2022-10-20 18:50:57 ~18 min macos 📦bin
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 71b065e #2 2022-10-21 11:02:34 ~17 min linux 📦bin
✔️ 71b065e #2 2022-10-21 11:04:55 ~20 min macos 📦bin
✔️ e2cbe79 #3 2022-10-21 11:06:07 ~15 min linux 📦bin
✔️ e2cbe79 #3 2022-10-21 11:09:53 ~19 min macos 📦bin

Copy link
Contributor

@alrevuelta alrevuelta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! the main module now is way easier to read!

@LNSD LNSD force-pushed the refactor-wakunode2-setupprocs branch from 71b065e to e2cbe79 Compare October 21, 2022 10:49
@LNSD LNSD merged commit c19081b into master Oct 21, 2022
@LNSD LNSD deleted the refactor-wakunode2-setupprocs branch October 21, 2022 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants