Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: run ci test workflows selectively #1284

Merged
merged 1 commit into from
Oct 20, 2022
Merged

ci: run ci test workflows selectively #1284

merged 1 commit into from
Oct 20, 2022

Conversation

LNSD
Copy link
Contributor

@LNSD LNSD commented Oct 20, 2022

GitHub actions have become a bottleneck for the PRs' review and merge process. Multiple improvements have been implemented:

  • CI job concurrency: Running jobs should be canceled when a newer version of the branch is pushed.
  • Checks for ignored files shall pass.
  • Differentiated CI workflows for waku v1/whisper and waku v2 sources:
    • test1: Executed when v1 or whisper sources or tests are modified. Always executed after merging into the master branch.
    • test2: Executed when v2 sources or tests are modified. Always executed after merging into the master branch.
  • Upgraded GitHub actions version for checkout and cache. Previous versions were deprecated.
  • Added ci/ and metrics/ directories to ignored paths list.

@LNSD LNSD added the infra Infra, devops, CI and related tasks label Oct 20, 2022
@LNSD LNSD self-assigned this Oct 20, 2022
@LNSD LNSD force-pushed the ci-test-selectivity branch from ada6fcd to 1eba5b2 Compare October 20, 2022 15:06
@status-im-auto
Copy link
Collaborator

status-im-auto commented Oct 20, 2022

Jenkins Builds

Click to see older builds (6)
Commit #️⃣ Finished (UTC) Duration Platform Result
⁉️ ada6fcd #1 2022-10-20 15:09:28 ~6 min linux 📄log
⁉️ ada6fcd #1 2022-10-20 15:11:03 ~7 min macos 📄log
⁉️ 1eba5b2 #2 2022-10-20 15:13:58 ~7 min linux 📄log
⁉️ 1eba5b2 #2 2022-10-20 15:18:06 ~11 min macos 📄log
⁉️ 6fd1c43 #3 2022-10-20 15:19:03 ~6 min linux 📄log
⁉️ 6fd1c43 #3 2022-10-20 15:20:22 ~7 min macos 📄log
Commit #️⃣ Finished (UTC) Duration Platform Result
⁉️ b294b8a #4 2022-10-20 15:20:28 ~6 min linux 📄log
⁉️ b294b8a #4 2022-10-20 15:25:55 ~12 min macos 📄log
✔️ 91a6da4 #5 2022-10-20 15:53:13 ~16 min linux 📦bin
✔️ 91a6da4 #5 2022-10-20 15:54:12 ~17 min macos 📦bin

@LNSD LNSD force-pushed the ci-test-selectivity branch 2 times, most recently from 6fd1c43 to b294b8a Compare October 20, 2022 15:13
@LNSD LNSD force-pushed the ci-test-selectivity branch from b294b8a to 91a6da4 Compare October 20, 2022 15:36
@LNSD LNSD marked this pull request as ready for review October 20, 2022 16:09
@LNSD LNSD requested a review from jm-clius October 20, 2022 16:09
Copy link
Contributor

@jm-clius jm-clius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@LNSD
Copy link
Contributor Author

LNSD commented Oct 20, 2022

The macOS workflow has failed due to an intermittent issue in waku v2. Merging this PR

@LNSD LNSD merged commit 339914b into master Oct 20, 2022
@LNSD LNSD deleted the ci-test-selectivity branch October 20, 2022 16:44
@rymnc
Copy link
Contributor

rymnc commented Oct 20, 2022

Thanks for this PR 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra Infra, devops, CI and related tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants