Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rln-relay): removes the Goerli account address config option from the onchain-rln-relay tutorial #1280

Merged
merged 3 commits into from
Oct 28, 2022

Conversation

staheri14
Copy link
Contributor

The Goerli account address is an optional flag, and this PR updates the onchain-rln-relay tutorial by removing the Goerli account address from the list of necessary config options.

@status-im-auto
Copy link
Collaborator

status-im-auto commented Oct 19, 2022

Jenkins Builds

Click to see older builds (2)
Commit #️⃣ Finished (UTC) Duration Platform Result
⁉️ 6f7cc1c #1 2022-10-19 21:02:59 ~5 min linux 📄log
⁉️ 6f7cc1c #1 2022-10-19 21:04:26 ~7 min macos 📄log
Commit #️⃣ Finished (UTC) Duration Platform Result
⁉️ ede2629 #2 2022-10-20 19:38:25 ~5 min linux 📄log
⁉️ ede2629 #2 2022-10-20 19:39:38 ~6 min macos 📄log
⁉️ b32e171 #3 2022-10-28 07:10:12 ~5 min linux 📄log
⁉️ b32e171 #3 2022-10-28 07:11:24 ~6 min macos 📄log

@staheri14 staheri14 requested review from s1fr0 and kaiserd October 19, 2022 23:04
Copy link
Contributor

@s1fr0 s1fr0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rymnc rymnc added this to the Release 0.13.0 milestone Oct 20, 2022
@LNSD LNSD added the track:rln RLN Track (Secure Messaging/Applied ZK), e.g. relay and applications label Oct 20, 2022
@status-im-auto
Copy link
Collaborator

✔️ nim-waku/prs/linux/PR-1280#2 🔹 ~5 min 14 sec 🔹 ede2629 🔹 📦 linux package

Copy link
Contributor

@kaiserd kaiserd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rymnc
Copy link
Contributor

rymnc commented Oct 28, 2022

Merging since the PR has had 2 approvals for a while now.

@rymnc rymnc merged commit 697c122 into master Oct 28, 2022
@rymnc rymnc deleted the rln-relay/update-tutorial-with-optional-account-address branch October 28, 2022 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
track:rln RLN Track (Secure Messaging/Applied ZK), e.g. relay and applications
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants