Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(rln-relay): Changes the test scenario of testnet2 tutorial to one chat user #1261

Merged
merged 7 commits into from
Oct 20, 2022
Merged

chore(rln-relay): Changes the test scenario of testnet2 tutorial to one chat user #1261

merged 7 commits into from
Oct 20, 2022

Conversation

staheri14
Copy link
Contributor

This PR updates the testnet2 tutorial by clarifying that running multiple chat clients is not mandatory rather an option for better illustration of spam protection.

@staheri14 staheri14 requested review from oskarth and s1fr0 October 12, 2022 23:18
@staheri14
Copy link
Contributor Author

@oskarth Please let me know if further clarification is needed.

@staheri14 staheri14 changed the title chore(rln-relay): Changes the test scenario of textnet2 tutorial to one chat user chore(rln-relay): Changes the test scenario of testnet2 tutorial to one chat user Oct 12, 2022
@status-im-auto
Copy link
Collaborator

status-im-auto commented Oct 12, 2022 •
edited
Loading

Jenkins Builds

Click to see older builds (10)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
⁉️ 0ceb8e5 #1 2022-10-12 23:24:46 ~6 min linux 📄log
⁉️ 0ceb8e5 #1 2022-10-12 23:27:22 ~9 min macos 📄log
⁉️ b7e67ec #2 2022-10-12 23:26:16 ~5 min linux 📄log
⁉️ b7e67ec #2 2022-10-12 23:26:44 ~6 min macos 📄log
⁉️ a02597f #3 2022-10-17 22:55:59 ~5 min linux 📄log
⁉️ a02597f #3 2022-10-17 23:02:08 ~11 min macos 📄log
⁉️ bd5d788 #4 2022-10-18 17:43:47 ~5 min linux 📄log
⁉️ bd5d788 #4 2022-10-18 17:45:17 ~6 min macos 📄log
⁉️ 99c6bd8 #5 2022-10-19 01:07:44 ~5 min linux 📄log
⁉️ 99c6bd8 #5 2022-10-19 01:13:29 ~10 min macos 📄log
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
⁉️ 435eedb #6 2022-10-19 18:42:16 ~5 min linux 📄log
⁉️ 435eedb #6 2022-10-19 18:47:42 ~10 min macos 📄log
⁉️ 5fb913a #7 2022-10-20 16:29:33 ~5 min linux 📄log
⁉️ 5fb913a #7 2022-10-20 16:34:59 ~10 min macos 📄log

@staheri14 staheri14 requested review from jm-clius and rymnc October 13, 2022 15:51
s1fr0
s1fr0 approved these changes Oct 17, 2022
View reviewed changes
Copy link
Contributor

@s1fr0 s1fr0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@staheri14 staheri14 added the track:rln RLN Track (Secure Messaging/Applied ZK), e.g. relay and applications label Oct 18, 2022
rymnc
rymnc approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@rymnc rymnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks :)

@staheri14 staheri14 merged commit 46d4e95 into master Oct 20, 2022
@staheri14 staheri14 deleted the rln-relay/testnet2-tutorial-update branch October 20, 2022 16:37
@alrevuelta alrevuelta mentioned this pull request Nov 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jm-clius jm-clius jm-clius approved these changes

@rymnc rymnc rymnc approved these changes

@s1fr0 s1fr0 s1fr0 approved these changes

@oskarth oskarth Awaiting requested review from oskarth

Assignees
No one assigned
Labels
track:rln RLN Track (Secure Messaging/Applied ZK), e.g. relay and applications
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@staheri14 @status-im-auto @s1fr0 @rymnc @jm-clius