chore(rln-relay): disable merkle root validation #1246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rymnc
added
the
track:rln
Jenkins BuildsClick to see older builds (2)
|
oskarth
reviewed
Oct 6, 2022
| return MessageValidationResult.Invalid | ||
| ## TODO: FIXME | ||
| # if not rlnPeer.validateRoot(msg.proof.merkleRoot): | ||
| # debug "invalid message: provided root does not belong to acceptable window of roots", provided=msg.proof.merkleRoot, validRoots=rlnPeer.validMerkleRoots |
There was a problem hiding this comment.
Instead of commenting this out, better to INFO/WRN log this
oskarth
reviewed
Oct 6, 2022
| ## TODO: FIXME | ||
| # if not rlnPeer.validateRoot(msg.proof.merkleRoot): | ||
| # debug "invalid message: provided root does not belong to acceptable window of roots", provided=msg.proof.merkleRoot, validRoots=rlnPeer.validMerkleRoots | ||
| # waku_rln_invalid_messages_total.inc(labelValues=["invalid_root"]) |
There was a problem hiding this comment.
Good point, bringing it back
There was a problem hiding this comment.
This and log above makes it easier to debug, especially with other PRs to improve connectivity robustness
| # if not rlnPeer.validateRoot(msg.proof.merkleRoot): | ||
| # debug "invalid message: provided root does not belong to acceptable window of roots", provided=msg.proof.merkleRoot, validRoots=rlnPeer.validMerkleRoots | ||
| # waku_rln_invalid_messages_total.inc(labelValues=["invalid_root"]) | ||
| # return MessageValidationResult.Invalid |
There was a problem hiding this comment.
This is only part that should be commented out for now, ideally with link to issue to fix
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @staheri19 for reliability of waku-rln-relay on the test fleet while we investigate and
resolve the issue