Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(wakunode2): deprecate non-async protocol api methods #1108

Merged
merged 1 commit into from
Sep 2, 2022

Conversation

LNSD
Copy link
Contributor

@LNSD LNSD commented Sep 1, 2022

Continuing with the wakunode2 file refactoring and protocol refactoring:

  • Removed the deprecated methods from the protocols
  • Use the async version of the deprecated methods in wakunode2
  • Deprecated the old handler (non-async) methods

This is part of the groundwork necessary for #1076

@LNSD LNSD requested review from kaiserd, rymnc and jm-clius September 1, 2022 13:06
@LNSD LNSD self-assigned this Sep 1, 2022
@LNSD LNSD force-pushed the refactor-wakunode2-deprecate-non-async branch from 7c56d4e to 93f87f5 Compare September 1, 2022 16:39
Copy link
Contributor

@jm-clius jm-clius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see!

@LNSD LNSD merged commit 21e9f25 into master Sep 2, 2022
@LNSD LNSD deleted the refactor-wakunode2-deprecate-non-async branch September 2, 2022 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants