chore: saving peers enr capabilities #3127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can find the image built from this PR at Built from a8eb49e |
gabrielmer
changed the title
gabrielmer
force-pushed
the
chore-saving-pers-enr-capabilities
branch
from
f642319 to
8b4f6f6
Compare
gabrielmer
commented
Oct 18, 2024
There was a problem hiding this comment.
Had to move some variables around as many were unnecessary in a global scope and gave issues related to GC safety.
Also, changed the validEnr value because apparently that ENR was missing fields
gabrielmer
requested review from
Ivansete-status,
NagyZoltanPeter,
darshankabariya,
richard-ramos and
jm-clius
5 tasks
Ivansete-status
approved these changes
Oct 23, 2024
gabrielmer
force-pushed
the
chore-saving-pers-enr-capabilities
branch
from
eb1fa68 to
cf24b36
Compare
NagyZoltanPeter
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When adding peers, we used to ignore the protocols advertised in the ENR and would fill the protocols in the Peer Store only after performing Identify.
We're now initializing the protocols with the advertised capabilities and will get updated once Identify is performed.
When mapping the ENR's capabilities to the supported protocols, we assume that the peers use the same version of the protocol as ours. If that's not the case, we'll find out during Identify, update the information and act accordingly.
In addition to that, started adding the Discv5 bootstrap nodes to the Peer Store.
I moved all the Waku protocols codec definitions to a separate file, as in the current state we had to import most of a protocol even if we only needed a codec, which caused circular dependency issues. Protocol codecs are public information, so it makes sense to be able to access them without having to import an entire protocol :)
Changes
RemotePeerInfo