implementing feedback

waku-org · Oct 24, 2024 · eb1fa68 · eb1fa68
1 parent 9db0c1e
commit eb1fa68
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 4 deletions.
diff --git a/tests/test_waku_enr.nim b/tests/test_waku_enr.nim
@@ -110,7 +110,7 @@ suite "Waku ENR -  Capabilities bitfield":
       let recordRes = builder.build()
 
       ## Then
-      check recordRes.isOk()
+      assert recordRes.isOk(), $recordRes.error
       let record = recordRes.tryGet()
 
       let codecs = record.getCapabilitiesCodecs()

diff --git a/tests/waku_core/test_peers.nim b/tests/waku_core/test_peers.nim
@@ -164,7 +164,7 @@ suite "Waku Core - Peers":
     let recordRes = builder.build()
 
     ## Then
-    check recordRes.isOk()
+    assert recordRes.isOk(), $recordRes.error
     let record = recordRes.tryGet()
 
     let remotePeerInfoRes = record.toRemotePeerInfo()

diff --git a/waku/factory/node_factory.nim b/waku/factory/node_factory.nim
@@ -398,13 +398,19 @@ proc startNode*(
     return err("failed to start waku node: " & getCurrentExceptionMsg())
 
   # Connect to configured static nodes
-  if conf.relay and conf.staticnodes.len > 0:
+  if conf.staticnodes.len > 0:
+    if not conf.relay:
+      return err("waku relay (--relay=true) should be set when configuring staticnodes")
     try:
       await connectToNodes(node, conf.staticnodes, "static")
     except CatchableError:
       return err("failed to connect to static nodes: " & getCurrentExceptionMsg())
 
-  if conf.relay and dynamicBootstrapNodes.len > 0:
+  if dynamicBootstrapNodes.len > 0:
+    if not conf.relay:
+      return err(
+        "waku relay (--relay=true) should be set when configuring dynamicBootstrapNodes"
+      )
     info "Connecting to dynamic bootstrap peers"
     try:
       await connectToNodes(node, dynamicBootstrapNodes, "dynamic bootstrap")