You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Lightpush service nodes will currently attempt to publish/relay messages received from clients without checking the message validity first.
Messages may violate violation rules for a variety of different reasons, including exceeding the maximum size, having an invalid RLN proof, etc. See the network spec for more.
This prevents the lightpush service node from returning an appropriate error message to the client.
At least two reported bugs will be fixed with message validation checking in the lightpush service node:
Considering "Provision RLN for light push clients PoC" milestone, this does not seem needed at this point in time.
This will be the first step for a RLN proofs service (validating the message - with provisioned proof - before publishing). In fact, I think this issue can be closed with the merging of #2695. @shash256 please confirm and close if addressed.
Problem
Lightpush service nodes will currently attempt to publish/relay messages received from clients without checking the message validity first.
Messages may violate violation rules for a variety of different reasons, including exceeding the maximum size, having an invalid RLN proof, etc. See the network spec for more.
This prevents the lightpush service node from returning an appropriate error message to the client.
At least two reported bugs will be fixed with message validation checking in the lightpush service node:
Validation checking in the Relay REST API can be used as inspiration:
nwaku/waku/waku_api/rest/relay/handlers.nim
Lines 155 to 156 in 006d43a
More resources: lightpush spec
Acceptance criteria
The text was updated successfully, but these errors were encountered: