Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(rln-relay): light push does not check proofs before forwarding to relay #1226

Closed
richard-ramos opened this issue Oct 5, 2022 · 3 comments
Assignees
Labels
bug Something isn't working effort/weeks Estimated to be completed in a few weeks

Comments

@richard-ramos
Copy link
Member

richard-ramos commented Oct 5, 2022

When a messge is published via lightpush, the message is broadcasted via relay without performing the rln proof verification. Ideally the proof should be verified before the message is published.

To see this scenario in action, use the following setup

A: js-waku
B: wakunode2 (with lightpush + filter, compiled with `RLNZEROKIT=true`)
C: chat2 (with rln-relay=true, rln-relay-dynamic=true, fleet=none and dns-discovery=false, compiled with `RLNZEROKIT=true`)

A --> B <-- C

https://examples.waku.org/rln-js/ can be used for the js-waku node.

A message generated in js-waku node should not arrive to chat2

cc: @staheri14 @fryorcraken

@richard-ramos richard-ramos added bug Something isn't working track:rln RLN Track (Secure Messaging/Applied ZK), e.g. relay and applications track:maintenance labels Oct 5, 2022
@oskarth oskarth added this to Vac Research and Waku Oct 5, 2022
@jm-clius jm-clius removed this from Waku Oct 5, 2022
@staheri14 staheri14 moved this to New in Vac Research Oct 14, 2022
@staheri14 staheri14 moved this from New to Next/Backlog in Vac Research Oct 14, 2022
@staheri14 staheri14 moved this from Next/Backlog to Later/Icebox in Vac Research Oct 14, 2022
@rymnc rymnc added track:rlnp2p and removed track:rln RLN Track (Secure Messaging/Applied ZK), e.g. relay and applications labels Jan 19, 2023
@fryorcraken fryorcraken added this to Waku Aug 22, 2023
@chair28980 chair28980 moved this to To Do in Waku Sep 26, 2023
@Ivansete-status
Copy link
Collaborator

@jm-clius - I've assigned this issue to @shash256 just to make it more explicit that this is part of #2595

@Ivansete-status Ivansete-status added the effort/weeks Estimated to be completed in a few weeks label May 8, 2024
@fryorcraken
Copy link
Collaborator

Considering "Provision RLN for light push clients PoC" milestone, this does not seem needed at this point in time.

@jm-clius
Copy link
Contributor

Considering "Provision RLN for light push clients PoC" milestone, this does not seem needed at this point in time.

This will be implemented as a side effect of the first step for a RLN proofs service (validating the message before publishing, whether the proof was added by the lightpush client or the RLN service node). In fact, I think this issue can be closed with the merging of #2695. @shash256 please confirm and close if addressed.

@github-project-automation github-project-automation bot moved this from To Do to Done in Waku Jun 11, 2024
@github-project-automation github-project-automation bot moved this from Later/Icebox to Done in Vac Research Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working effort/weeks Estimated to be completed in a few weeks
Projects
Archived in project
Development

No branches or pull requests

6 participants