Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(store): retention policy regex #2532

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Conversation

richard-ramos
Copy link
Member

Description

Allows the usage of optional decimal values in the storage policy, and limits the size unit in the regexp itself. Since i preeventively lowercase the ret policy argument, I ended up removing the different combinations of uppercase/lowercase and just compare against gb or mb.

Issue

closes #2522

Copy link

github-actions bot commented Mar 13, 2024

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2532-rln-v2-false

Built from c1a4aec

Copy link
Collaborator

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful! Thanks! 💯

Copy link
Contributor

@SionoiS SionoiS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@richard-ramos richard-ramos merged commit 23a291b into master Mar 15, 2024
13 of 15 checks passed
@richard-ramos richard-ramos deleted the fix/ret-policy-regex branch March 15, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: store size retention policy parsing fails for string define fraction number.
3 participants