chore: Enable external configuration of DB storage size retention policy #77
Conversation
NagyZoltanPeter
requested review from
SionoiS,
alrevuelta,
gabrielmer and
Ivansete-status
run_node.sh
Outdated
| if [[ ! "${STORAGE_SIZE}" =~ ^[0-9]*\.?[0-9]+[MG]B$ ]]; then | ||
| echo "Invalid STORAGE_SIZE value: \"${STORAGE_SIZE}\". Please use a valid size format (e.g. 1GB, 120MB, 1.5GB)." | ||
| exit 1 | ||
| fi |
There was a problem hiding this comment.
Do we really need this if the node already spit an error with a wrong format as input?
It's more user friendly this way I guess...
There was a problem hiding this comment.
Yes, I saw just this: waku-org/nwaku#2532
So I will remove this to allow to be checked in one place... more future proof you're right.
The user either case needs to check the logs ....
There was a problem hiding this comment.
Thank you!
We should probably also add this variable to https://github.com/waku-org/nwaku-compose/blob/master/.env.example and https://github.com/waku-org/nwaku-compose/blob/master/ADVANCED.md
Thank you for draw attention on it. I added the description and .env placeholder. |
NagyZoltanPeter
deleted the
chore-enable-configurable-store-retention-size
branch
Add STORAGE_SIZE config to enable storage size retention externally, deafult to 1GB
We think regular users may not accept several / dozens of GB databases created on their disks while try waku node via nwaku-compose.
With the new better managed Postgress db size retention mechanism it is better to set some lower DB size limit by default (1GB) which still allows several hours of messages to be stored and yet allow operator / testers to set allowed DB size to their needs.
This command can be used with this PR:
STORAGE_SIZE=1500MB docker compose up -d