Skip to content

Commit

Permalink
fix(rln-relay): remove poParentStream, remove ganache log output
Browse files Browse the repository at this point in the history
  • Loading branch information
rymnc committed Jan 25, 2023
1 parent f5c2f88 commit 29a541d
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion tests/v2/test_rln_group_manager_onchain.nim
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ proc runGanache(): Process =
# --wallet.defaultBalance The default account balance, specified in ether.
# See ganache documentation https://www.npmjs.com/package/ganache for more details
try:
let runGanache = startProcess("npx", args = ["--yes", "ganache", "--port", "8540", "--miner.blockGasLimit", "300000000000000", "--wallet.defaultBalance", "10000"], options = {poUsePath, poParentStreams})
let runGanache = startProcess("npx", args = ["--yes", "ganache", "--port", "8540", "--miner.blockGasLimit", "300000000000000", "--wallet.defaultBalance", "10000"], options = {poUsePath})
let ganachePID = runGanache.processID

# We read stdout from Ganache to see when daemon is ready
Expand Down Expand Up @@ -149,6 +149,9 @@ proc stopGanache(runGanache: Process) {.used.} =
try:
# We terminate Ganache daemon by sending a SIGTERM signal to the runGanache PID to trigger RPC server termination and clean-up
terminate(runGanache)
# NOTE: the below line must remain commented out, otherwise it will cause a deadlocked state
# ref: https://nim-lang.org/docs/osproc.html#waitForExit%2CProcess%2Cint
# debug "ganache logs", logs=runGanache.outputstream.readAll()
debug "Sent SIGTERM to Ganache", ganachePID=ganachePID
except:
error "Ganache daemon termination failed: ", err = getCurrentExceptionMsg()
Expand Down

0 comments on commit 29a541d

Please sign in to comment.