Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rest light push #818

Merged
merged 8 commits into from
Oct 23, 2023
Merged

Rest light push #818

merged 8 commits into from
Oct 23, 2023

Conversation

harsh-98
Copy link
Contributor

Description

Add Lightpush publish message REST endpoint.

Changes

  • Rest endpoint
  • Tests

Tests

  • Ran new test and prev test

Issue

#813

@status-im-auto
Copy link

status-im-auto commented Oct 19, 2023 •
edited
Loading

Jenkins Builds

Click to see older builds (34)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✖️ 3204ba8 #1 2023-10-19 03:29:21 ~1 min tests 📄log
✖️ 3204ba8 #1 2023-10-19 03:29:21 ~1 min tests 📄log
✔️ 3204ba8 #1 2023-10-19 03:29:52 ~1 min nix-flake 📄log
✔️ 3204ba8 #1 2023-10-19 03:30:26 ~2 min linux 📦deb
✔️ 3204ba8 #1 2023-10-19 03:32:27 ~4 min android 📦tgz
✔️ 3204ba8 #1 2023-10-19 03:33:42 ~5 min ios 📦tgz
✔️ 9a55414 #2 2023-10-19 03:46:50 ~1 min linux 📦deb
✔️ 9a55414 #2 2023-10-19 03:47:40 ~1 min nix-flake 📄log
✔️ 9a55414 #2 2023-10-19 03:48:10 ~2 min tests 📄log
✔️ 9a55414 #2 2023-10-19 03:49:12 ~3 min android 📦tgz
✔️ 9a55414 #2 2023-10-19 03:49:58 ~4 min ios 📦tgz
✖️ 9a55414 #2 2023-10-19 03:51:28 ~5 min tests 📄log
✖️ 9a55414 #3 2023-10-19 03:59:38 ~6 min tests 📄log
✖️ 9a55414 #4 2023-10-19 04:35:02 ~1 min tests 📄log
✔️ 9a55414 #5 2023-10-19 04:37:55 ~2 min tests 📄log
✔️ c9a339b #3 2023-10-19 04:43:35 ~59 sec linux 📦deb
✔️ c9a339b #3 2023-10-19 04:44:28 ~1 min nix-flake 📄log
✔️ c9a339b #6 2023-10-19 04:45:52 ~3 min tests 📄log
✔️ c9a339b #3 2023-10-19 04:46:00 ~3 min android 📦tgz
✔️ c9a339b #3 2023-10-19 04:46:03 ~3 min tests 📄log
✔️ c9a339b #3 2023-10-19 04:46:37 ~4 min ios 📦tgz
✖️ 0161bcb #7 2023-10-20 09:00:46 ~1 min tests 📄log
✖️ 0161bcb #4 2023-10-20 09:00:46 ~1 min tests 📄log
✔️ 0161bcb #4 2023-10-20 09:01:01 ~2 min nix-flake 📄log
✔️ 0161bcb #4 2023-10-20 09:01:36 ~2 min linux 📦deb
✔️ 0161bcb #4 2023-10-20 09:03:19 ~4 min android 📦tgz
✔️ 0161bcb #4 2023-10-20 09:04:26 ~5 min ios 📦tgz
✖️ 0161bcb #8 2023-10-21 11:09:26 ~21 sec tests 📄log
✔️ 40e7409 #5 2023-10-21 11:13:30 ~1 min linux 📦deb
✔️ 40e7409 #5 2023-10-21 11:13:31 ~1 min tests 📄log
✔️ 40e7409 #5 2023-10-21 11:14:18 ~1 min nix-flake 📄log
✔️ 40e7409 #9 2023-10-21 11:15:37 ~3 min tests 📄log
✔️ 40e7409 #5 2023-10-21 11:16:09 ~3 min android 📦tgz
✔️ 40e7409 #5 2023-10-21 11:17:39 ~5 min ios 📦tgz
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 6956840 #6 2023-10-23 22:58:49 ~1 min linux 📦deb
✔️ 6956840 #6 2023-10-23 22:59:36 ~1 min nix-flake 📄log
✔️ 6956840 #10 2023-10-23 23:00:00 ~2 min tests 📄log
✔️ 6956840 #6 2023-10-23 23:01:08 ~3 min tests 📄log
✔️ 6956840 #6 2023-10-23 23:01:17 ~3 min android 📦tgz
✔️ 6956840 #6 2023-10-23 23:01:28 ~3 min ios 📦tgz
✔️ 039065e #7 2023-10-23 23:19:54 ~1 min linux 📦deb
✔️ 039065e #7 2023-10-23 23:20:37 ~1 min tests 📄log
✔️ 039065e #7 2023-10-23 23:20:41 ~1 min nix-flake 📄log
✔️ 039065e #11 2023-10-23 23:21:06 ~2 min tests 📄log
✔️ 039065e #7 2023-10-23 23:22:18 ~3 min ios 📦tgz
✔️ 039065e #7 2023-10-23 23:22:49 ~3 min android 📦tgz

@harsh-98 harsh-98 marked this pull request as ready for review October 19, 2023 03:59
@harsh-98
Copy link
Contributor Author

The failing test, is unrelated to this PR. node test is failing due to test timeout of 300 secs.

richard-ramos
richard-ramos reviewed Oct 19, 2023
View reviewed changes
Copy link
Member

@richard-ramos richard-ramos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Left some comments of things that should probably be addressed before merging!

cmd/waku/server/rest/lightpush_rest.go Outdated Show resolved Hide resolved
cmd/waku/server/rest/waku_rest.go Show resolved Hide resolved
cmd/waku/server/rest/lightpush_rest.go Outdated Show resolved Hide resolved
chaitanyaprem
chaitanyaprem reviewed Oct 19, 2023
View reviewed changes
Copy link
Collaborator

@chaitanyaprem chaitanyaprem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Left some comments.

cmd/waku/server/rest/lightpush_api.yaml Show resolved Hide resolved
cmd/waku/server/rest/lightpush_api.yaml Show resolved Hide resolved
cmd/waku/server/rest/lightpush_api.yaml Show resolved Hide resolved
cmd/waku/server/rest/lightpush_api.yaml Show resolved Hide resolved
cmd/waku/server/rest/lightpush_rest_test.go Show resolved Hide resolved
@chaitanyaprem
Copy link
Collaborator

The failing test, is unrelated to this PR. node test is failing due to test timeout of 300 secs.

Maybe just rerun that check to ensure it passes. That will rule out it is nothing to do with this PR.

@harsh-98 harsh-98 merged commit 9b9fc63 into master Oct 23, 2023
1 check passed
@harsh-98 harsh-98 deleted the RestLightPush branch October 23, 2023 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NagyZoltanPeter NagyZoltanPeter NagyZoltanPeter left review comments

@chaitanyaprem chaitanyaprem chaitanyaprem left review comments

@richard-ramos richard-ramos richard-ramos approved these changes

Assignees

@harsh-98 harsh-98

Labels
None yet
Projects
Waku
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@harsh-98 @status-im-auto @chaitanyaprem @richard-ramos @NagyZoltanPeter