Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optimize Filter Ping towards peers #1099

Closed
chaitanyaprem opened this issue May 13, 2024 · 0 comments · Fixed by #1102
Closed

feat: optimize Filter Ping towards peers #1099

chaitanyaprem opened this issue May 13, 2024 · 0 comments · Fixed by #1102
Assignees

Comments

@chaitanyaprem
Copy link
Collaborator

chaitanyaprem commented May 13, 2024

Background

As part of #1048 , moving Filter subscription management to go-waku and multiplexing channels towards users is being accomplished. But if there are multiple susbcriptions towards a peer, it can lead to multiple Filter ping requests every 5 seconds which is not optimal and doesn't scale.

Need to optimize the same so that a single Filter Ping is sent towards a peer.

Details

This kind of logic can be moved to peer-Manager along with maintaining healthy connections towards Filter-Peers(TBD: analyze)

Acceptance criteria

Unit tests to validate Filter pings based on different subscriptions towards a single peer.

@chaitanyaprem chaitanyaprem self-assigned this May 13, 2024
@fryorcraken fryorcraken added this to Waku May 13, 2024
@chaitanyaprem chaitanyaprem linked a pull request May 16, 2024 that will close this issue
3 tasks
@chaitanyaprem chaitanyaprem moved this to In Progress in Waku May 16, 2024
@chaitanyaprem chaitanyaprem moved this from In Progress to Code Review / QA in Waku May 21, 2024
@github-project-automation github-project-automation bot moved this from Code Review / QA to Done in Waku May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant