-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dry-configurable v0.11.0 breaks this gem #21
Comments
Hi @nuqz. Same problem here. Could you come up with a work around until the problem is fixed? |
@rezam90 you can specify the gem dry-configurator as 0.9 in your gem file and it should start working. |
Break do to dry-configurable #78, seems |
But @Mansh05, when can we get a complete proper fix!? |
Also the gem is
|
dry-configurable got updated as a dependency after
In production mode, it fails during startup when migrations attempt to run:
As per Mansh05, specifying the lower version of dry-configurable in my Gemfile seems to work-around the problem.
|
* Allow declined participants to register/login
I kept the version 0.11.1 but in devise settings I called the fields to evaluate eagerly before warden because after the version 0.9.0 the gem dry-configurable evaluates settings lazy. # devise.rb
#...
config.jwt do |jwt|
jwt.secret = ENV['DEVISE_SECRET_KEY']
jwt.dispatch_requests = [
['POST', %r{^/login$}]
]
jwt.dispatch_requests
jwt.revocation_requests = [
['DELETE', %r{^/logout$}]
]
jwt.revocation_requests
jwt.expiration_time = 5.minutes.to_i
end It's working as well! |
Hey folks, for now just lock dry-configurable version in your Gemfile. I'll fix it as soon as possible (PR's more than welcome!) |
Fixed. It was a regression in dry-configurable and it has been fixed there. I've released v0.4.1 of warden-jwt_auth depending on a version at least equal that the one containing the fix. |
As it's taking longer than expected to be fixed upstream in dry-configurable, I have released a new version 0.4.2 which locks itself dry-configurable version. This way, once it's updated there I'll just release a new version and it'll be transparent for the user. |
* Allow declined participants to register/login
I apologize for the brevity, but my time is running out.
Expected behavior
No errors after
bundle install
and/orbundle update
.Actual behavior
Steps to Reproduce the Problem
bundle update
, ensuredry-configurable
was updated to 0.11 (which actually satisfies~> 0.8
)rails c
Debugging information
warden-jwt_auth
in use - 0.4The text was updated successfully, but these errors were encountered: