Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix DeskGap author link on credits page #3724

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

matta
Copy link
Contributor

@matta matta commented Sep 3, 2024

Description

The DeskGap author appears to have moved from https://github.com/patr0nus/ (now a 404) to https://github.com/branchseer

Type of change

Please delete options that are not relevant.

  • This change requires a documentation update

How Has This Been Tested?

Visual inspection of diff.

Test Configuration

n/a

Checklist:

  • I have updated website/src/pages/changelog.mdx with details of this PR
  • My code follows the general coding style of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Summary by CodeRabbit

  • New Features

    • Updated the GitHub link for contributor Wang, Chi across multiple language versions of the credits section to reflect the correct profile.
  • Bug Fixes

    • Corrected the attribution link for Wang, Chi to ensure proper acknowledgment of contributions.

Copy link
Contributor

coderabbitai bot commented Sep 3, 2024

Walkthrough

The changes involve a minor update to the credits section across various localization files and the main credits file. Specifically, the GitHub link for the contributor Wang, Chi has been updated from https://github.com/patr0nus/ to https://github.com/branchseer. This adjustment is purely for attribution purposes and does not impact any functionality or logic within the codebase.

Changes

Files Change Summary
website/i18n/ar/docusaurus-plugin-content-pages/credits.mdx Updated GitHub link for contributor Wang, Chi from patr0nus to branchseer.
website/i18n/fr/docusaurus-plugin-content-pages/credits.mdx Updated GitHub link for contributor Wang, Chi from patr0nus to branchseer.
website/i18n/ja/docusaurus-plugin-content-pages/credits.mdx Updated GitHub link for contributor Wang, Chi from patr0nus to branchseer.
website/i18n/ko/docusaurus-plugin-content-pages/credits.mdx Updated GitHub link for contributor Wang, Chi from patr0nus to branchseer.
website/i18n/pt/docusaurus-plugin-content-pages/credits.mdx Updated GitHub link for contributor Wang, Chi from patr0nus to branchseer.
website/i18n/ru/docusaurus-plugin-content-pages/credits.mdx Updated GitHub link for contributor Wang, Chi from patr0nus to branchseer.
website/i18n/tr/docusaurus-plugin-content-pages/credits.mdx Updated GitHub link for contributor Wang, Chi from patr0nus to branchseer.
website/i18n/vi/docusaurus-plugin-content-pages/credits.mdx Updated GitHub link for contributor Wang, Chi from patr0nus to branchseer.
website/i18n/zh-Hans/docusaurus-plugin-content-pages/credits.mdx Updated GitHub link for contributor Wang, Chi from patr0nus to branchseer.
website/src/pages/credits.mdx Updated GitHub link for contributor Wang, Chi from patr0nus to branchseer.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant CreditsPage
    participant GitHub

    User->>CreditsPage: View credits
    CreditsPage->>GitHub: Fetch contributor links
    GitHub-->>CreditsPage: Return updated link for Wang, Chi
    CreditsPage-->>User: Display updated credits
Loading

Poem

🐇
In the meadow where rabbits play,
A link was changed, hip-hip-hooray!
From patr0nus to branchseer,
We hop with joy, let’s give a cheer!
For every change, a tale to tell,
In the credits, all is well!
🐇

Tip

We have updated our review workflow to use the Anthropic's Claude family of models. Please share any feedback in the discussion post on our Discord.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

sonarcloud bot commented Sep 3, 2024

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 3721d73 and b812d12.

Files selected for processing (10)
  • website/i18n/ar/docusaurus-plugin-content-pages/credits.mdx (1 hunks)
  • website/i18n/fr/docusaurus-plugin-content-pages/credits.mdx (1 hunks)
  • website/i18n/ja/docusaurus-plugin-content-pages/credits.mdx (1 hunks)
  • website/i18n/ko/docusaurus-plugin-content-pages/credits.mdx (1 hunks)
  • website/i18n/pt/docusaurus-plugin-content-pages/credits.mdx (1 hunks)
  • website/i18n/ru/docusaurus-plugin-content-pages/credits.mdx (1 hunks)
  • website/i18n/tr/docusaurus-plugin-content-pages/credits.mdx (1 hunks)
  • website/i18n/vi/docusaurus-plugin-content-pages/credits.mdx (1 hunks)
  • website/i18n/zh-Hans/docusaurus-plugin-content-pages/credits.mdx (1 hunks)
  • website/src/pages/credits.mdx (1 hunks)
Files skipped from review due to trivial changes (9)
  • website/i18n/ar/docusaurus-plugin-content-pages/credits.mdx
  • website/i18n/ja/docusaurus-plugin-content-pages/credits.mdx
  • website/i18n/ko/docusaurus-plugin-content-pages/credits.mdx
  • website/i18n/pt/docusaurus-plugin-content-pages/credits.mdx
  • website/i18n/ru/docusaurus-plugin-content-pages/credits.mdx
  • website/i18n/tr/docusaurus-plugin-content-pages/credits.mdx
  • website/i18n/vi/docusaurus-plugin-content-pages/credits.mdx
  • website/i18n/zh-Hans/docusaurus-plugin-content-pages/credits.mdx
  • website/src/pages/credits.mdx
Additional context used
LanguageTool
website/i18n/fr/docusaurus-plugin-content-pages/credits.mdx

[typographical] ~268-~268: Ce signe est un trait d’union, il ne sert qu’à former des mots composés. Employez un tiret ou un autre signe de ponctuation plus approprié.
Context: ...nt permis de publier la v2. - Wang, Chi - Le projet DeskGap a été une grande influen...

(TIRET)

Additional comments not posted (1)
website/i18n/fr/docusaurus-plugin-content-pages/credits.mdx (1)

268-268: LGTM!

The change updates the GitHub link for the contributor Wang, Chi from https://github.com/patr0nus/ to https://github.com/branchseer. This is a minor update for attribution purposes and does not impact any functionality.

Tools
LanguageTool

[typographical] ~268-~268: Ce signe est un trait d’union, il ne sert qu’à former des mots composés. Employez un tiret ou un autre signe de ponctuation plus approprié.
Context: ...nt permis de publier la v2. - Wang, Chi - Le projet DeskGap a été une grande influen...

(TIRET)

@leaanthony
Copy link
Member

How do we know that's them? 😄

@matta
Copy link
Contributor Author

matta commented Sep 4, 2024

How do we know that's them? 😄

I went by https://github.com/branchseer/DeskGap/ and theduke/quickjs-rs#114 (comment). The latter thread mentions all three identities, as if patr0nus was renamed to branchseer after the thread occurred.

@leaanthony
Copy link
Member

Looks legit. Thanks for doing this 🙏
image

@leaanthony leaanthony merged commit f4b21a6 into wailsapp:master Sep 5, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants