-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix DeskGap author link on credits page #3724
Conversation
WalkthroughThe changes involve a minor update to the credits section across various localization files and the main credits file. Specifically, the GitHub link for the contributor Wang, Chi has been updated from Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant CreditsPage
participant GitHub
User->>CreditsPage: View credits
CreditsPage->>GitHub: Fetch contributor links
GitHub-->>CreditsPage: Return updated link for Wang, Chi
CreditsPage-->>User: Display updated credits
Poem
Tip We have updated our review workflow to use the Anthropic's Claude family of models. Please share any feedback in the discussion post on our Discord. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (10)
- website/i18n/ar/docusaurus-plugin-content-pages/credits.mdx (1 hunks)
- website/i18n/fr/docusaurus-plugin-content-pages/credits.mdx (1 hunks)
- website/i18n/ja/docusaurus-plugin-content-pages/credits.mdx (1 hunks)
- website/i18n/ko/docusaurus-plugin-content-pages/credits.mdx (1 hunks)
- website/i18n/pt/docusaurus-plugin-content-pages/credits.mdx (1 hunks)
- website/i18n/ru/docusaurus-plugin-content-pages/credits.mdx (1 hunks)
- website/i18n/tr/docusaurus-plugin-content-pages/credits.mdx (1 hunks)
- website/i18n/vi/docusaurus-plugin-content-pages/credits.mdx (1 hunks)
- website/i18n/zh-Hans/docusaurus-plugin-content-pages/credits.mdx (1 hunks)
- website/src/pages/credits.mdx (1 hunks)
Files skipped from review due to trivial changes (9)
- website/i18n/ar/docusaurus-plugin-content-pages/credits.mdx
- website/i18n/ja/docusaurus-plugin-content-pages/credits.mdx
- website/i18n/ko/docusaurus-plugin-content-pages/credits.mdx
- website/i18n/pt/docusaurus-plugin-content-pages/credits.mdx
- website/i18n/ru/docusaurus-plugin-content-pages/credits.mdx
- website/i18n/tr/docusaurus-plugin-content-pages/credits.mdx
- website/i18n/vi/docusaurus-plugin-content-pages/credits.mdx
- website/i18n/zh-Hans/docusaurus-plugin-content-pages/credits.mdx
- website/src/pages/credits.mdx
Additional context used
LanguageTool
website/i18n/fr/docusaurus-plugin-content-pages/credits.mdx
[typographical] ~268-~268: Ce signe est un trait d’union, il ne sert qu’à former des mots composés. Employez un tiret ou un autre signe de ponctuation plus approprié.
Context: ...nt permis de publier la v2. - Wang, Chi - Le projet DeskGap a été une grande influen...(TIRET)
Additional comments not posted (1)
website/i18n/fr/docusaurus-plugin-content-pages/credits.mdx (1)
268-268
: LGTM!The change updates the GitHub link for the contributor Wang, Chi from
https://github.com/patr0nus/
tohttps://github.com/branchseer
. This is a minor update for attribution purposes and does not impact any functionality.Tools
LanguageTool
[typographical] ~268-~268: Ce signe est un trait d’union, il ne sert qu’à former des mots composés. Employez un tiret ou un autre signe de ponctuation plus approprié.
Context: ...nt permis de publier la v2. - Wang, Chi - Le projet DeskGap a été une grande influen...(TIRET)
How do we know that's them? 😄 |
I went by https://github.com/branchseer/DeskGap/ and theduke/quickjs-rs#114 (comment). The latter thread mentions all three identities, as if patr0nus was renamed to branchseer after the thread occurred. |
Description
The DeskGap author appears to have moved from https://github.com/patr0nus/ (now a 404) to https://github.com/branchseer
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Visual inspection of diff.
Test Configuration
n/a
Checklist:
website/src/pages/changelog.mdx
with details of this PRSummary by CodeRabbit
New Features
Bug Fixes