[V3] Refactor linux ignore mouse events

[atterpac]

Description

Recent changes to ignoring mouse events introduced a compile time error on linux due to using GDK C calls without access to the GDK C Lib.

This PR moves the calls to linux_cgo and adds a call to the function in the webview_window_linux.go

Fixes

Linux compile brought up in discord

Doctor

# System
┌──────────────────────────────────────────────────────────────────────────────────────────┐
| Name         | Ubuntu                                                                    |
| Version      | 24.04                                                                     |
| ID           | ubuntu                                                                    |
| Branding     | 24.04 LTS (Noble Numbat)                                                  |
| Platform     | linux                                                                     |
| Architecture | amd64                                                                     |
| CPU          | 12th Gen Intel(R) Core(TM) i5-1235U                                       |
| GPU 1        | Alder Lake-UP3 GT2 [Iris Xe Graphics] (Intel Corporation) - Driver: i915  |
| Memory       | 7GB                                                                       |
└──────────────────────────────────────────────────────────────────────────────────────────┘

# Build Environment
┌─────────────────────────────────────────────────────────┐
| Wails CLI    | v3.0.0-alpha.6                           |
| Go Version   | go1.22.4                                 |
| Revision     | 2460b570fe80dd78b83cc701421213ad8cb1d073 |
| Modified     | true                                     |
| -buildmode   | exe                                      |
| -compiler    | gc                                       |
| CGO_CFLAGS   |                                          |
| CGO_CPPFLAGS |                                          |
| CGO_CXXFLAGS |                                          |
| CGO_ENABLED  | 1                                        |
| CGO_LDFLAGS  |                                          |
| GOAMD64      | v1                                       |
| GOARCH       | amd64                                    |
| GOOS         | linux                                    |
| vcs          | git                                      |
| vcs.modified | true                                     |
| vcs.revision | 2460b570fe80dd78b83cc701421213ad8cb1d073 |
| vcs.time     | 2024-09-02T09:33:17Z                     |
└─────────────────────────────────────────────────────────┘

# Dependencies
┌──────────────────────────────────────────────────────────────────────────────────┐
| gcc        | 12.10ubuntu1                                                        |
| gtk3       | 3.24.41-4ubuntu1.1                                                  |
| npm        | 10.5.1                                                              |
| pkg-config | 1.8.1-2build1                                                       |
| webkit2gtk | not installed. Install with: sudo apt install libwebkit2gtk-4.1-dev |
└──────────────────────────── * - Optional Dependency ─────────────────────────────┘

Summary by CodeRabbit

• New Features

  • Enhanced mouse event handling for the Linux application, allowing for more granular control over interactions.

• Bug Fixes

  • Resolved a Linux compile error related to mouse event handling.
  • Fixed a Windows syso icon file generation issue.
  • Improved compatibility with Wayland.
  • Addressed a system tray startup panic.

• Documentation

  • Updated changelog to reflect recent bug fixes and enhancements.

[coderabbitai]

Walkthrough

The changes include an update to the changelog to document a fix for a Linux compile error related to mouse event handling. Additionally, modifications were made to the linuxWebviewWindow struct, introducing a new method for controlling mouse event reception and simplifying existing methods for managing mouse event ignoring. These updates enhance the structure and functionality of the code related to mouse event management.

Changes

Files	Change Summary
mkdocs-website/docs/en/changelog.md	Added entry for fix on Linux compile error related to IgnoreMouseEvents, linked to PR #3721.
v3/pkg/application/linux_cgo.go	Introduced ignoreMouse method to manage GTK widget event handling based on a boolean parameter.
v3/pkg/application/webview_window_linux.go	Simplified setIgnoreMouseEvents method to call ignoreMouse, refactoring mouse event handling.

Poem

In a world where events dance and sway,
A rabbit hops in joy today! 🐇
With mouse events now in control,
Our GTK widget plays its role.
Hooray for fixes, bright and new,
A leap of code, a joyful view! 🌟

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

Early access features: disabled

We are currently testing the following features in early access:

• Anthropic claude-3-5-sonnet for code reviews: Anthropic claims that the new Claude model has stronger code understanding and code generation capabilities than their previous models. Note: Our default code review model was also updated late last week. Please compare the quality of the reviews between the two models by toggling the early access feature.

Note:

• You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.
• Please join our Discord Community to provide feedback and report issues on the discussion post.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 2460b57 and baf6f7e.

Files selected for processing (3)

• mkdocs-website/docs/en/changelog.md (1 hunks)
• v3/pkg/application/linux_cgo.go (1 hunks)
• v3/pkg/application/webview_window_linux.go (3 hunks)

Files skipped from review due to trivial changes (1)

• mkdocs-website/docs/en/changelog.md

Additional comments not posted (2)

v3/pkg/application/webview_window_linux.go (1)

377-377: Refactoring of mouse event handling logic

The change simplifies the setIgnoreMouseEvents method by delegating the mouse event handling logic to the ignoreMouse method. This refactoring aims to encapsulate the complex logic for managing mouse events based on the ignoreMouseEvents property within the ignoreMouse method.

The AI-generated summary suggests that this change is a part of a larger refactoring effort to improve the structure and functionality of the code related to mouse event management.

v3/pkg/application/linux_cgo.go (1)

1376-1382: LGTM!

The new ignoreMouse method looks good. It correctly sets the appropriate event masks on the GTK widget based on the ignore parameter to control mouse event handling.